Skip to content

Conversation

@torokati44
Copy link
Member

@torokati44 torokati44 commented Nov 30, 2024

Hopefully #18397 can be reverted after: #18399

Also, this will make one commit unnecessary in the upcoming #18761 (comment).
EDIT: No, I got confused, that was about something else.

@torokati44 torokati44 added A-build Area: Build scripts & CI T-chore Type: Chore (like updating a dependency, it's gotta be done) labels Nov 30, 2024
@danielhjacobs
Copy link
Contributor

Hopefully #18397 can be reverted after: #18399

Worth a test, but I'm not so sure. wasm-bindgen/wasm-bindgen#4213 was replaced by wasm-bindgen/wasm-bindgen#4235, which did not do anywhere near the same thing.

@danielhjacobs
Copy link
Contributor

Instead, #18528 will probably have to be merged followed by a follow-up to use that environment variable on CI to build an MVP vanilla WASM module, then #18399 can be merged.

@danielhjacobs
Copy link
Contributor

image

That's with this branch: Commit 3cd21aabc7861887542e7bc93595951ff7f10b2c

@danielhjacobs
Copy link
Contributor

wasm-bindgen/wasm-bindgen#4211 (comment)

Copy link
Contributor

@danielhjacobs danielhjacobs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently this may fix Safari 15+.

@torokati44 torokati44 merged commit a466802 into ruffle-rs:master Dec 2, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-build Area: Build scripts & CI T-chore Type: Chore (like updating a dependency, it's gotta be done)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants