Skip to content

web: Improve error when WASM extensions are unsupported but only the module which uses them is available #18838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2025
Merged

web: Improve error when WASM extensions are unsupported but only the module which uses them is available #18838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9e40eb
web: Throw an error when reference types are unsupported
danielhjacobs Dec 2, 2024
7af4d6b
web: Check error message on browsers without reference types support
danielhjacobs Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions web/packages/core/src/internal/ui/panic.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,19 @@ function createPanicError(error: Error | null): {
};
}

if (error.cause.name === "CompileError" && message.includes("bad type")) {
// Self hosted: User has a browser without support for necessary WebAssembly extensions
return {
body: textAsParagraphs("error-wasm-unsupported-browser"),
actions: [
CommonActions.openWiki(
"#web",
),
CommonActions.ShowDetails,
],
};
}

if (error.cause.name === "CompileError") {
// Self hosted: Cannot load `.wasm` file - incorrect configuration or missing files
return {
Expand Down
4 changes: 4 additions & 0 deletions web/packages/core/texts/en-US/messages.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,10 @@ error-wasm-disabled-on-edge =
To fix this, try opening your browser's settings, clicking "Privacy, search, and services", scrolling down, and turning off "Enhance your security on the web".
This will allow your browser to load the required ".wasm" files.
If the issue persists, you might have to use a different browser.
error-wasm-unsupported-browser =
The browser you are using does not support the WebAssembly extensions Ruffle requires to run.
Please switch to a supported browser.
You can find a list of supported browsers on the Wiki.
error-javascript-conflict =
Ruffle has encountered a major issue whilst trying to initialize.
It seems like this page uses JavaScript code that conflicts with Ruffle.
Expand Down