Skip to content

Commit 8588c9c

Browse files
committed
Bumping to v2.4.6
1 parent f958b9b commit 8588c9c

10 files changed

+32
-19
lines changed

CHANGELOG.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,16 @@
11
# Changelog
22

3+
## v2.4.6
4+
5+
#### Breaking Changes
6+
* None
7+
8+
#### New Features
9+
* None
10+
11+
#### Bug Fixes
12+
* Bug #109 - Properly remove event listeners on destroy
13+
314
## v2.4.5
415

516
#### Breaking Changes

bower.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "angular-color-picker",
33
"description": "Color Picker Directive For AngularJS",
4-
"version": "2.4.5",
4+
"version": "2.4.6",
55
"homepage": "https://github.com/ruhley/angular-color-picker",
66
"repository": {
77
"type": "git",

dist/angularjs-color-picker.css

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/angularjs-color-picker.js

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
/*!
2-
* angularjs-color-picker v2.4.5
2+
* angularjs-color-picker v2.4.6
33
* https://github.com/ruhley/angular-color-picker/
44
*
55
* Copyright 2016 ruhley
66
*
7-
* 2016-09-07 15:01:47
7+
* 2016-09-09 08:58:41
88
*
99
*/
1010

@@ -230,6 +230,7 @@ var AngularColorPickerController = function () {
230230
up: this.onMouseUp.bind(this),
231231
move: this.onMouseMove.bind(this)
232232
};
233+
233234
// needed variables
234235
this.updateModel = true;
235236

@@ -290,9 +291,9 @@ var AngularColorPickerController = function () {
290291
this.$document.on('mousemove', mouseEventHandlers.move);
291292

292293
// setup touch events
293-
this.$document.on('touchstart', this.onMouseDown.bind(this));
294-
this.$document.on('touchend', this.onMouseUp.bind(this));
295-
this.$document.on('touchmove', this.onMouseMove.bind(this));
294+
this.$document.on('touchstart', mouseEventHandlers.down);
295+
this.$document.on('touchend', mouseEventHandlers.up);
296+
this.$document.on('touchmove', mouseEventHandlers.move);
296297

297298
// grid click
298299
this.find('.color-picker-grid').on('click', this.onColorClick.bind(this));

dist/angularjs-color-picker.min.css

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/angularjs-color-picker.min.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/themes/angularjs-color-picker-bootstrap.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
/*!
2-
* angularjs-color-picker v2.4.5
2+
* angularjs-color-picker v2.4.6
33
* https://github.com/ruhley/angular-color-picker/
44
*
55
* Copyright 2016 ruhley
66
*
7-
* 2016-09-07 13:57:51
7+
* 2016-09-09 08:58:43
88
*
99
*/
1010
.color-picker-wrapper .color-picker-input-wrapper {
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
/*!
2-
* angularjs-color-picker v2.4.5
2+
* angularjs-color-picker v2.4.6
33
* https://github.com/ruhley/angular-color-picker/
44
*
55
* Copyright 2016 ruhley
66
*
7-
* 2016-09-07 13:57:51
7+
* 2016-09-09 08:58:43
88
*
99
*/.color-picker-wrapper .color-picker-input-wrapper{width:100%}.color-picker-wrapper .color-picker-swatch:not(.input-group-addon){height:28px}.color-picker-wrapper.color-picker-swatch-only .input-group .input-group-addon{border-radius:4px}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "angularjs-color-picker",
33
"description": "Color Picker Directive For AngularJS",
4-
"version": "2.4.5",
4+
"version": "2.4.6",
55
"license": "MIT",
66
"main": "dist/angularjs-color-picker.min.js",
77
"dependencies": {

src/scripts/controller.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,8 @@ export default class AngularColorPickerController {
166166
down: this.onMouseDown.bind(this),
167167
up: this.onMouseUp.bind(this),
168168
move: this.onMouseMove.bind(this)
169-
}
169+
};
170+
170171
// needed variables
171172
this.updateModel = true;
172173

0 commit comments

Comments
 (0)