Skip to content

Commit 87a03a8

Browse files
committed
Bumping to v2.4.8
1 parent 16eff08 commit 87a03a8

9 files changed

+42
-21
lines changed

CHANGELOG.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,16 @@
11
# Changelog
22

3+
## v2.4.8
4+
5+
#### Breaking Changes
6+
* None
7+
8+
#### New Features
9+
* None
10+
11+
#### Bug Fixes
12+
* Bug #115 - Touch events not getting proper position
13+
314
## v2.4.7
415

516
#### Breaking Changes

bower.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "angular-color-picker",
33
"description": "Color Picker Directive For AngularJS",
4-
"version": "2.4.7",
4+
"version": "2.4.8",
55
"homepage": "https://github.com/ruhley/angular-color-picker",
66
"repository": {
77
"type": "git",

dist/angularjs-color-picker.css

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/angularjs-color-picker.js

Lines changed: 18 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
/*!
2-
* angularjs-color-picker v2.4.7
2+
* angularjs-color-picker v2.4.8
33
* https://github.com/ruhley/angular-color-picker/
44
*
55
* Copyright 2016 ruhley
66
*
7-
* 2016-09-20 08:25:47
7+
* 2016-09-26 08:41:56
88
*
99
*/
1010

@@ -714,7 +714,9 @@ var AngularColorPickerController = function () {
714714
event.preventDefault();
715715

716716
var el = this.find('.color-picker-hue');
717-
this.hue = (1 - (event.pageY - this.offset(el).top) / el.prop('offsetHeight')) * 360;
717+
var eventPos = this.getEventPos(event);
718+
719+
this.hue = (1 - (eventPos.pageY - this.offset(el).top) / el.prop('offsetHeight')) * 360;
718720

719721
if (this.hue > 360) {
720722
this.hue = 360;
@@ -768,7 +770,9 @@ var AngularColorPickerController = function () {
768770
event.preventDefault();
769771

770772
var el = this.find('.color-picker-opacity');
771-
this.opacity = (1 - (event.pageY - this.offset(el).top) / el.prop('offsetHeight')) * 100;
773+
var eventPos = this.getEventPos(event);
774+
775+
this.opacity = (1 - (eventPos.pageY - this.offset(el).top) / el.prop('offsetHeight')) * 100;
772776

773777
if (this.opacity > 100) {
774778
this.opacity = 100;
@@ -820,11 +824,12 @@ var AngularColorPickerController = function () {
820824
event.preventDefault();
821825

822826
var el = this.find('.color-picker-grid-inner');
827+
var eventPos = this.getEventPos(event);
823828
var offset = this.offset(el);
824829

825830
if (this.options.round) {
826-
var dx = (event.pageX - offset.left) * 2.0 / el.prop('offsetWidth') - 1.0;
827-
var dy = -((event.pageY - offset.top) * 2.0 / el.prop('offsetHeight')) + 1.0;
831+
var dx = (eventPos.pageX - offset.left) * 2.0 / el.prop('offsetWidth') - 1.0;
832+
var dy = -((eventPos.pageY - offset.top) * 2.0 / el.prop('offsetHeight')) + 1.0;
828833

829834
var tmpSaturation = Math.sqrt(dx * dx + dy * dy);
830835
var tmpHue = Math.atan2(dy, dx);
@@ -837,8 +842,8 @@ var AngularColorPickerController = function () {
837842
this.hue = degHue;
838843
this.lightness = 100;
839844
} else {
840-
this.saturation = (event.pageX - offset.left) / el.prop('offsetWidth') * 100;
841-
this.lightness = (1 - (event.pageY - offset.top) / el.prop('offsetHeight')) * 100;
845+
this.saturation = (eventPos.pageX - offset.left) / el.prop('offsetWidth') * 100;
846+
this.lightness = (1 - (eventPos.pageY - offset.top) / el.prop('offsetHeight')) * 100;
842847

843848
if (this.saturation > 100) {
844849
this.saturation = 100;
@@ -914,6 +919,11 @@ var AngularColorPickerController = function () {
914919
// helper functions
915920
//---------------------------
916921

922+
}, {
923+
key: 'getEventPos',
924+
value: function getEventPos(event) {
925+
return event.type.search('touch') === 0 ? event.changedTouches[0] : event;
926+
}
917927
}, {
918928
key: 'eventApiDispatch',
919929
value: function eventApiDispatch(name, args) {

dist/angularjs-color-picker.min.css

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/angularjs-color-picker.min.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/themes/angularjs-color-picker-bootstrap.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
/*!
2-
* angularjs-color-picker v2.4.7
2+
* angularjs-color-picker v2.4.8
33
* https://github.com/ruhley/angular-color-picker/
44
*
55
* Copyright 2016 ruhley
66
*
7-
* 2016-09-20 08:25:49
7+
* 2016-09-26 08:41:59
88
*
99
*/
1010
.color-picker-wrapper .color-picker-input-wrapper {
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
/*!
2-
* angularjs-color-picker v2.4.7
2+
* angularjs-color-picker v2.4.8
33
* https://github.com/ruhley/angular-color-picker/
44
*
55
* Copyright 2016 ruhley
66
*
7-
* 2016-09-20 08:25:49
7+
* 2016-09-26 08:41:59
88
*
99
*/.color-picker-wrapper .color-picker-input-wrapper{width:100%}.color-picker-wrapper .color-picker-swatch:not(.input-group-addon){height:28px}.color-picker-wrapper.color-picker-swatch-only .input-group .input-group-addon{border-radius:4px}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "angularjs-color-picker",
33
"description": "Color Picker Directive For AngularJS",
4-
"version": "2.4.7",
4+
"version": "2.4.8",
55
"license": "MIT",
66
"main": "dist/angularjs-color-picker.min.js",
77
"dependencies": {

0 commit comments

Comments
 (0)