fix: enable running in incognito mode for recorder

Author: qiubowen

examples/recorder-crx/src/background.ts

@@ -73,11 +73,11 @@ async function changeAction(tabId: number, mode?: CrxMode | 'detached') {
 // https://bugs.chromium.org/p/chromium/issues/detail?id=1450904
 chrome.tabs.onUpdated.addListener(tabId => changeAction(tabId));
 
-async function getCrxApp() {
+async function getCrxApp(isIncognito: boolean) {
   if (!crxAppPromise) {
     await settingsInitializing;
 
-    crxAppPromise = crx.start().then(crxApp => {
+    crxAppPromise = crx.start( { incognito: isIncognito } ).then(crxApp => {
       crxApp.recorder.addListener('hide', async () => {
         await crxApp.detachAll();
       });
@@ -104,6 +104,13 @@ async function getCrxApp() {
 async function attach(tab: chrome.tabs.Tab, mode?: Mode) {
   if (!tab?.id || (attachedTabIds.has(tab.id) && !mode))
     return;
+   // if the tab is incognito, chek if can be started in incognito mode.
+  if (tab.incognito) {
+    if (!await chrome.extension.isAllowedIncognitoAccess() || !settings.playInIncognito) {
+      console.error('Not authorized to launch in Incognito mode.');
+      return;
+    }
+  }
   const tabId = tab.id;
 
   const sidepanel = !isUnderTest() && settings.sidepanel;
@@ -114,8 +121,7 @@ async function attach(tab: chrome.tabs.Tab, mode?: Mode) {
 
   // ensure one attachment at a time
   chrome.action.disable();
-
-  const crxApp = await getCrxApp();
+  const crxApp = await getCrxApp(tab.incognito);
 
   try {
     if (crxApp.recorder.isHidden()) {

src/server/crx.ts

@@ -138,21 +138,17 @@ export class Crx extends SdkObject {
   private async _startIncognitoCrxApplication(browser: CRBrowser, transport: CrxTransport, options?: channels.BrowserNewContextParams) {
     const windows = await chrome.windows.getAll().catch(() => {}) ?? [];
     const windowId = windows.find(window => window.incognito)?.id;
-    const incognitoTabIdPromise = new Promise<number>(resolve => {
-      const tabCreated = (tab: chrome.tabs.Tab) => {
-        if (!tab.incognito || !tab.id)
-          return;
-        chrome.tabs.onCreated.removeListener(tabCreated);
-        resolve(tab.id);
-      };
-      chrome.tabs.onCreated.addListener(tabCreated);
-    });
     if (!windowId)
       chrome.windows.create({ incognito: true, url: 'about:blank' });
     else
-      chrome.tabs.create({ url: 'about:blank', windowId });
-
-    const incognitoTabId = await incognitoTabIdPromise;
+      // do not create but find exists one
+      chrome.tabs.query({windowId: windowId}, (tabIds) => {
+        if (!tabIds) {
+          chrome.tabs.create({ url: 'about:blank', windowId });
+        }
+      })
+
+    const incognitoTabId = (await chrome.tabs.query({windowId: windowId, active: true}))[0].id!;
     let context!: CRBrowserContext;
     await transport.attach(incognitoTabId, async ({ browserContextId }) => {
       // ensure we create and initialize the new context before the Target.attachedToTarget event is emitted