Commit 10a6571
committed
fix: raise ValueError when 'model' is passed instead of 'model_name' in BedrockEmbedding
Raises a clear ValueError when users pass model= instead of model_name=
to BedrockEmbedding. Previously, model= was silently absorbed by **kwargs
and ignored, causing the default model (amazon.titan-embed-text-v1) to be
used unexpectedly.
Bump llama-index-embeddings-bedrock version to 0.7.4.1 parent 59b4cc6 commit 10a6571
File tree
4 files changed
+15
-2
lines changed- llama-index-integrations/embeddings/llama-index-embeddings-bedrock
- llama_index/embeddings/bedrock
- tests
4 files changed
+15
-2
lines changedLines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
147 | 147 | | |
148 | 148 | | |
149 | 149 | | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
150 | 156 | | |
151 | 157 | | |
152 | 158 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
| 30 | + | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| |||
llama-index-integrations/embeddings/llama-index-embeddings-bedrock/tests/test_bedrock_embedding.py
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
12 | 19 | | |
13 | 20 | | |
14 | 21 | | |
| |||
Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments