rc.5: updating to TypeScript 4.4, tslib 2.3, and adding more overloads

Author: Tynarus

package-lock.json

@@ -1,6 +1,6 @@
 {
     "name": "@runejs/common",
-    "version": "2.0.0-rc.3",
+    "version": "2.0.0-rc.5",
     "description": "Common logging, networking, compression, and other functionality for RuneJS applications.",
     "main": "lib/index.js",
     "types": "lib/index.d.ts",
@@ -29,12 +29,16 @@
         "url": "https://github.com/runejs/core/issues"
     },
     "homepage": "https://github.com/runejs/core#readme",
+    "peerDependencies": {
+        "tslib": ">=2.3.0",
+        "typescript": ">=4.4.0"
+    },
     "dependencies": {
         "compressjs": "^1.0.3",
         "js-yaml": "^3.14.1",
         "pino": "^6.13.0",
         "pino-pretty": "^4.8.0",
-        "tslib": ">=2.1.0"
+        "tslib": "^2.3.1"
     },
     "devDependencies": {
         "@runejs/eslint-config": "^1.0.0",
@@ -44,11 +48,8 @@
         "@typescript-eslint/parser": "^4.29.3",
         "eslint": "^7.32.0",
         "rimraf": "^3.0.2",
-        "ts-node": "^9.1.1",
-        "typescript": ">=4.2.0"
-    },
-    "peerDependencies": {
-        "tslib": ">=2.1.0"
+        "ts-node": "^10.3.0",
+        "typescript": "^4.4.4"
     },
     "eslintConfig": {
         "extends": [

package.json

@@ -94,6 +94,7 @@ export class ByteBuffer extends Uint8Array {
     public get(type: Extract<DataType, 'string' | 'STRING'>): string;
     public get(type: Extract<DataType, 'long' | 'LONG'>, signed?: Signedness, endian?: Endianness): bigint;
     public get(type: Exclude<DataType, 'string' | 'STRING' | 'long' | 'LONG'>, signed?: Signedness, endian?: Endianness): number;
+    public get(type?: DataType, signed?: Signedness, endian?: Endianness): number | bigint | string;
     public get(type: DataType = 'byte', signed: Signedness = 'signed', endian: Endianness = 'be'): number | bigint | string {
         type = ByteBuffer.getType(type);
         signed = ByteBuffer.getSignage(signed);

src/buffer/byte-buffer.ts

@@ -102,15 +102,22 @@ export abstract class SocketServer<T = undefined> {
         this.connectionDestroyed();
     }
 
-    public error(error: any): void {
-        logger.error('Socket destroyed due to error:');
-        logger.error(error);
+    public error(error: Error): void;
+    public error(error: { message?: string }): void;
+    public error(error: string): void;
+    public error(error: any | Error | { message?: string } | string): void;
+    public error(error: any | Error | { message?: string } | string): void {
+        if(error && typeof error === 'string') {
+            error = { message: error };
+        }
+
+        logger.error('Socket destroyed due to error' + error?.message ? `: ${error.message}` : '.');
 
         try {
             this.closeConnection();
         } catch(closeConnectionError) {
-            logger.error(`Error closing server connection:`);
-            logger.error(closeConnectionError);
+            logger.error('Error closing server connection' +
+            closeConnectionError?.message ? `: ${closeConnectionError.message}` : '.');
         }
     }