refactor: make caches private

Author: Jameskmonger

src/main/java/org/runejs/client/Landscape.java

@@ -221,7 +221,7 @@ public static void loadRegion() {
                         MovedStatics.spawnGroundItem(y, x);
                 }
                 clearTemporaryObjects();
-                GameObjectDefinition.modelCacheStatic.clear();
+                GameObjectDefinition.clearStaticModelCache();
                 if(GameShell.clientFrame != null) {
                     OutgoingPackets.buffer.putPacket(121);
                     OutgoingPackets.buffer.putIntBE(1057001181);

src/main/java/org/runejs/client/cache/def/GameObjectDefinition.java

@@ -20,10 +20,10 @@ public class GameObjectDefinition extends CachedNode implements EntityDefinition
     public static int count;
     public static int[] OBJECT_TYPES = new int[]{0, 0, 0, 0, 1, 1, 1, 1, 1, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 3};
     public static boolean lowMemory = false;
-    public static CacheArchive definitionArchive;
-    public static CacheArchive modelArchive;
+    private static CacheArchive definitionArchive;
+    private static CacheArchive modelArchive;
     private static NodeCache definitionCache = new NodeCache(64);
-    public static NodeCache modelCacheStatic = new NodeCache(500);
+    private static NodeCache modelCacheStatic = new NodeCache(500);
     private static Model[] objectModelHolder = new Model[4];
     private static NodeCache modelCacheDynamic = new NodeCache(10);
     private static NodeCache animatedObjectModelCache = new NodeCache(30);
@@ -186,6 +186,10 @@ public static void clearGameObjectModelCache() {
         animatedObjectModelCache.clear();
     }
 
+    public static void clearStaticModelCache() {
+        modelCacheStatic.clear();
+    }
+
     public static void initializeGameObjectDefinitionCache(CacheArchive modelCache, boolean lowMemory, CacheArchive definitionCache) {
         GameObjectDefinition.definitionArchive = definitionCache;
         count = GameObjectDefinition.definitionArchive.fileLength(6);

src/main/java/org/runejs/client/cache/def/ItemDefinition.java

@@ -13,11 +13,11 @@
 
 public class ItemDefinition extends CachedNode implements EntityDefinition {
     public static int count;
-    public static CacheArchive definitionArchive;
-    public static NodeCache definitionCache = new NodeCache(64);
-    public static NodeCache modelCache = new NodeCache(50);
-    public static NodeCache imageCache = new NodeCache(100);
-    public static CacheArchive modelArchive;
+    private static CacheArchive definitionArchive;
+    private static NodeCache definitionCache = new NodeCache(64);
+    private static NodeCache modelCache = new NodeCache(50);
+    private static NodeCache imageCache = new NodeCache(100);
+    private static CacheArchive modelArchive;
 
     public int stackable;
     public String name;

src/main/java/org/runejs/client/cache/def/VarPlayerDefinition.java

@@ -6,8 +6,8 @@
 import org.runejs.client.node.NodeCache;
 
 public class VarPlayerDefinition extends CachedNode {
-    public static NodeCache varPlayerDefinitionCache = new NodeCache(64);
-    public static CacheArchive gameDefinitionsCacheArchive;
+    private static NodeCache varPlayerDefinitionCache = new NodeCache(64);
+    private static CacheArchive gameDefinitionsCacheArchive;
     public static int varPlayerDefinitionsSize;
     public static int[] varpCache = new int[2000];
     public int type = 0;

src/main/java/org/runejs/client/cache/def/VarbitDefinition.java

@@ -7,8 +7,8 @@
 import org.runejs.client.util.BitUtils;
 
 public class VarbitDefinition extends CachedNode {
-    public static NodeCache varbitDefinitionCache = new NodeCache(64);
-    public static CacheArchive gameDefinitionsCacheArchive;
+    private static NodeCache varbitDefinitionCache = new NodeCache(64);
+    private static CacheArchive gameDefinitionsCacheArchive;
 
     /**
      * Contains information on the bit mask to use per specified bits.