add helper function hasValueNotNull and prepare config ids for bank interface

Author: Promises

src/plugins/objects/bank/bank-booth-plugin.ts

@@ -17,7 +17,8 @@ export const openBankInterface: objectAction = (details) => {
 
     details.player.outgoingPackets.sendUpdateAllWidgetItems(widgets.bank.tabWidget, details.player.inventory);
     details.player.outgoingPackets.sendUpdateAllWidgetItems(widgets.bank.screenWidget, details.player.bank);
-
+    details.player.outgoingPackets.updateClientConfig(304, details.player.sessionMetadata['bankRearrangeMode'] === 'insert' ? 1 : 0);
+    details.player.outgoingPackets.updateClientConfig(115, details.player.sessionMetadata['bankWithdrawAs'] === 'note' ? 1 : 0);
 
 };
 

src/util/data.ts

@@ -0,0 +1,3 @@
+export function hasValueNotNull(variable: any): boolean {
+    return typeof variable !== 'undefined' && variable !== null;
+}

src/world/actor/player/player-data.ts

@@ -4,6 +4,7 @@ import { join } from 'path';
 import { logger } from '@runejs/logger';
 import { Player } from './player';
 import { SkillValue } from '@server/world/actor/skills';
+import { hasValueNotNull } from '@server/util/data';
 
 
 export interface QuestProgress {
@@ -124,7 +125,7 @@ export function savePlayerData(player: Player): boolean {
         appearance: player.appearance,
         inventory: player.inventory.items,
         bank: player.bank.items.filter((item) => {
-            return !!item;
+            return hasValueNotNull(item);
         }),
         equipment: player.equipment.items,
         skills: player.skills.values,

src/world/actor/player/player.ts

@@ -92,6 +92,7 @@ export class Player extends Actor {
     public readonly actionsCancelled: Subject<boolean>;
     private quadtreeKey: QuadtreeKey = null;
     public savedMetadata: { [key: string]: any } = {};
+    public sessionMetadata: { [key: string]: any } = {};
     public quests: QuestProgress[] = [];
     public achievements: string[] = [];
 

src/world/items/item-container.ts

@@ -1,6 +1,7 @@
 import { Item } from './item';
 import { Subject } from 'rxjs';
 import { cache, world } from '@server/game-server';
+import { hasValueNotNull } from '@server/util/data';
 
 export interface ContainerUpdateEvent {
     slot?: number;
@@ -43,7 +44,7 @@ export class ItemContainer {
         if (stackable) {
             const index = this.findIndex(search);
 
-            if (!index || index === -1) {
+            if (!hasValueNotNull(index) || index === -1) {
                 return [];
             } else {
                 return [index];
@@ -204,7 +205,7 @@ export class ItemContainer {
     }
 
     public getFirstOpenSlot(): number {
-        return this._items.findIndex(item => !item);
+        return this._items.findIndex(item => !hasValueNotNull(item));
     }
 
     public hasSpace(): boolean {
@@ -214,7 +215,7 @@ export class ItemContainer {
     public getOpenSlotCount(): number {
         let count = 0;
         for (let i = 0; i < this._size; i++) {
-            if (!this._items[i]) {
+            if (!hasValueNotNull(this._items[i])) {
                 count++;
             }
         }
@@ -226,7 +227,7 @@ export class ItemContainer {
         const slots: number[] = [];
 
         for (let i = 0; i < this._size; i++) {
-            if (!this._items[i]) {
+            if (!hasValueNotNull(this._items[i])) {
                 slots.push(i);
             }
         }
@@ -246,12 +247,12 @@ export class ItemContainer {
         let weight = 0;
 
         for (const item of this._items) {
-            if (!item) {
+            if (!hasValueNotNull(item)) {
                 continue;
             }
 
             const itemData = world.itemData.get(item.itemId);
-            if (!itemData || itemData.weight === undefined) {
+            if (!!hasValueNotNull(itemData) || itemData.weight === undefined) {
                 continue;
             }