Skip to content

Commit 6ca9840

Browse files
author
Spencer Carlson
committed
Fix:
Casing on item and NPC definitions to match the standard.
1 parent 68f8990 commit 6ca9840

File tree

3 files changed

+16
-16
lines changed

3 files changed

+16
-16
lines changed
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
{
2-
"rs:Fancy boots": {
2+
"rs:Fancy_boots": {
33
"game_id": 9005
44
},
5-
"rs:Fighting boots": {
5+
"rs:Fighting_boots": {
66
"game_id": 9006
77
}
88
}

data/config/npcs/dungeons/stronghold-of-security.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
{
2-
"rs:Gate of War": {
2+
"rs:Gate_of_War": {
33
"game_id": 4377
44
},
5-
"rs:Ricketty door": {
5+
"rs:Ricketty_door": {
66
"game_id": 4378
77
},
8-
"rs:Oozing barrier": {
8+
"rs:Oozing_barrier": {
99
"game_id": 4379
1010
},
11-
"rs:Portal of Death": {
11+
"rs:Portal_of_Death": {
1212
"game_id": 4380
1313
},
1414
"rs:Ankou": {

src/plugins/dungeons/stronghold-of-security/stronghold-of-security-rewards.plugin.ts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -48,19 +48,19 @@ export const getNpcKeyFromObjectId = (objectId: number): string => {
4848
switch (objectId) {
4949
case objectIds.strongholdOfSecurity.gates.gateOfWarLeft:
5050
case objectIds.strongholdOfSecurity.gates.gateOfWarRight:
51-
return `rs:Gate of War`;
51+
return `rs:Gate_of_War`;
5252

5353
case objectIds.strongholdOfSecurity.gates.ricketyDoorLeft:
5454
case objectIds.strongholdOfSecurity.gates.ricketyDoorRight:
55-
return `rs:Ricketty door`;
55+
return `rs:Ricketty_door`;
5656

5757
case objectIds.strongholdOfSecurity.gates.oozingBarrierLeft:
5858
case objectIds.strongholdOfSecurity.gates.oozingBarrierRight:
59-
return `rs:Oozing barrier`;
59+
return `rs:Oozing_barrier`;
6060

6161
case objectIds.strongholdOfSecurity.gates.thePortalOfDeathLeft:
6262
case objectIds.strongholdOfSecurity.gates.thePortalOfDeathRight:
63-
return `rs:Portal of Death`;
63+
return `rs:Portal_of_Death`;
6464
}
6565
}
6666

@@ -113,8 +113,8 @@ const activate = async (task: TaskExecutor<ObjectInteractionAction>, taskIterati
113113
const completedSepulchre = player.savedMetadata[`strongholdOfSecurityState`].floorCompletion.sepulchreOfDeath;
114114

115115
if (object.objectId === objectIds.strongholdOfSecurity.rewardObjects.cradleOfLife) {
116-
const fancyBoots = findItem(`rs:Fancy boots`);
117-
const fightingBoots = findItem(`rs:Fighting boots`);
116+
const fancyBoots = findItem(`rs:Fancy_boots`);
117+
const fightingBoots = findItem(`rs:Fighting_boots`);
118118

119119
const lostBoots = player.savedMetadata[`strongholdOfSecurityState`].floorCompletion.sepulchreOfDeath &&
120120
!(player.hasItemOnPerson(fancyBoots.gameId) || player.hasItemOnPerson(fightingBoots.gameId))
@@ -131,13 +131,13 @@ const activate = async (task: TaskExecutor<ObjectInteractionAction>, taskIterati
131131
options => [
132132
`I'll take the colourful ones!`, [
133133
execute(() => {
134-
player.giveItem(findItem(`rs:Fancy boots`).gameId);
134+
player.giveItem(findItem(`rs:Fancy_boots`).gameId);
135135
})
136136
],
137137

138138
`I'll take the fighting ones!`, [
139139
execute(() => {
140-
player.giveItem(findItem(`rs:Fighting boots`).gameId);
140+
player.giveItem(findItem(`rs:Fighting_boots`).gameId);
141141
})
142142
]
143143
],
@@ -183,15 +183,15 @@ const activate = async (task: TaskExecutor<ObjectInteractionAction>, taskIterati
183183
options => [
184184
`I'll take the colourful ones!`, [
185185
execute(() => {
186-
player.giveItem(findItem(`rs:Fancy boots`).gameId);
186+
player.giveItem(findItem(`rs:Fancy_boots`).gameId);
187187
unlockEmote(player, `STAMP`);
188188
player.savedMetadata[`strongholdOfSecurityState`].floorCompletion.sepulchreOfDeath = true;
189189
})
190190
],
191191

192192
`I'll take the fighting ones!`, [
193193
execute(() => {
194-
player.giveItem(findItem(`rs:Fighting boots`).gameId);
194+
player.giveItem(findItem(`rs:Fighting_boots`).gameId);
195195
unlockEmote(player, `STAMP`);
196196
player.savedMetadata[`strongholdOfSecurityState`].floorCompletion.sepulchreOfDeath = true;
197197
})

0 commit comments

Comments
 (0)