Fixing JS plugin hot reloading

Author: TheBlackParade

plugins/combat/combat.js

@@ -4,8 +4,9 @@ const action = async details => {
     const { player, npc } = details;
 
     npc.updateFlags.addDamage(1, DamageType.DAMAGE, 4, 5);
+    npc.say(`Ow!`);
 
-    await wait(1000);
+    await wait(100);
 
     player.updateFlags.addDamage(1, DamageType.DAMAGE, 9, 10);
 };

src/plugins/commands/reload-plugins.ts

@@ -7,6 +7,20 @@ const action: commandAction = (details) => {
 
     player.sendLogMessage('Reloading plugins...', details.isConsole);
 
+    // Delete node cache for all the old JS plugins
+    for(const path in require.cache) {
+        if(!path.endsWith('.js')) {
+            continue;
+        }
+        if(path.indexOf('node_modules') !== -1 || path.indexOf('dist') !== -1) {
+            continue;
+        }
+        if(path.indexOf('rune.js') !== -1 || path.indexOf('plugins') === -1) {
+            continue;
+        }
+
+        delete require.cache[path];
+    }
 
     injectPlugins()
         .then(() => player.sendLogMessage('Plugins reloaded.', details.isConsole))

src/plugins/plugin-loader.ts

@@ -57,7 +57,7 @@ export const pluginFilter = (pluginIds: number | number[], searchId: number, plu
 
 const readdir = util.promisify(fs.readdir);
 const stat = util.promisify(fs.stat);
-const blacklist = ['plugin-loader.js', 'plugin.js'];
+const blacklist = ['plugin-loader.js', 'plugin.js', 'rune.js'];
 
 async function* getFiles(directory: string): AsyncGenerator<string> {
     const files = await readdir(directory);