refactor: remove prayer plugin and effect system (only used by prayers)

Author: Jameskmonger

src/engine/world/actor/actor.ts

@@ -12,7 +12,6 @@ import { WalkingQueue } from './walking-queue';
 import { Animation, Graphic, UpdateFlags } from './update-flags';
 import { Skills } from './skills';
 import { Pathfinding } from './pathfinding';
-import { Effect } from './effect';
 import { ActorMetadata } from './metadata';
 
 
@@ -49,8 +48,6 @@ export abstract class Actor {
 
     public pathfinding: Pathfinding = new Pathfinding(this);
     public lastMovementPosition: Position;
-    // #region Behaviors and Combat flags/checks
-    public effects: Effect[] = []; //spells, effects, prayers, etc
 
     protected randomMovementInterval;
     protected _instance: WorldInstance = null;

src/engine/world/actor/effect.ts

@@ -1,6 +1,5 @@
 export * from './combat';
 export * from './dialogue';
-export * from './effect';
 export * from './magic';
 export * from './pathfinding';
 export * from './prayer';

src/engine/world/actor/index.ts

@@ -37,7 +37,6 @@ import { Cutscene } from './cutscenes';
 import { InterfaceState } from '@engine/interface';
 import { Quest } from './quest';
 import { SendMessageOptions } from './model';
-import { EffectType } from '../effect';
 import { PlayerSyncTask, NpcSyncTask } from './sync';
 import { dialogue } from '../dialogue';
 import { Npc } from '../npc';
@@ -777,10 +776,6 @@ export class Player extends Actor {
 
             this.addBonuses(item);
         }
-        //prayers and other effects that effect strength
-        this.effects.filter(a => a.EffectType === EffectType.Strength).forEach((effect) => {
-            this.bonuses.skill['strength'] += this.skills.strength.level * effect.Modifier;
-        });
     }
 
     public sendLogMessage(message: string, isConsole: boolean): void {

src/engine/world/actor/player/player.ts

@@ -1,7 +1,5 @@
-import { Effect, EffectType } from './effect';
-
-export class Prayer extends Effect {
+export class Prayer {
     AnimationId: number;
     SoundId: number;
     ButtonId: number;
-}
+}

src/engine/world/actor/prayer.ts

@@ -5,7 +5,6 @@ export * from './harvest-tool';
 export * from './harvestable-object';
 export * from './item-ids';
 export * from './object-ids';
-export * from './prayers';
 export * from './scenery-spawns';
 export * from './songs';
 export * from './sound-ids';