Refactored to naming convention,

Converted console.log to using logger

Author: Twistt

src/game-engine/net/inbound-packets/magic-attack-packet.ts

@@ -12,7 +12,7 @@ const magicAttackPacket = (player: Player, packet: PacketData) => {
     const widgetChildId = buffer.get(); // unsigned short LE
 
     const npc = world.npcList[npcWorldIndex];
-    //console.log(`actual spell being cast is ${widgetChildId}`);
+
     player.actionPipeline.call('magic_on_npc', npc, player, widgetId, widgetChildId);
 };
 

src/game-engine/world/action/magic-on-npc.action.ts

@@ -8,7 +8,7 @@ import { Npc } from '../actor/npc/npc';
 /**
  * Defines a button action hook.
  */
-export interface Magic_on_NPCActionHook extends ActionHook<Magic_on_NPCAction, magic_on_npcActionHandler> {
+export interface Magic_On_NPCActionHook extends ActionHook<Magic_On_NPCAction, magic_on_npcActionHandler> {
     // The npc world id that was clicked on after choosing the spell
     npcworldId?: number;
     // The IDs of the UI widgets that the buttons are on.
@@ -23,13 +23,13 @@ export interface Magic_on_NPCActionHook extends ActionHook<Magic_on_NPCAction, m
 /**
  * The button action hook handler function to be called when the hook's conditions are met.
  */
-export type magic_on_npcActionHandler = (buttonAction: Magic_on_NPCAction) => void | Promise<void>;
+export type magic_on_npcActionHandler = (buttonAction: Magic_On_NPCAction) => void | Promise<void>;
 
 
 /**
  * Details about a button action being performed.
  */
-export interface Magic_on_NPCAction {
+export interface Magic_On_NPCAction {
     // The npc world id that was clicked on after choosing the spell
     npc: Npc,
     // The player performing the action.
@@ -52,7 +52,7 @@ const buttonActionPipe = (npc:Npc, player: Player, widgetId: number, buttonId: n
     //console.info(`pew pew you use magic on ${npc.name}!`);
 
     // Find all object action plugins that reference this location object
-    let matchingHooks = getActionHooks<Magic_on_NPCActionHook>('magic_on_npc');
+    let matchingHooks = getActionHooks<Magic_On_NPCActionHook>('magic_on_npc');
 
 
     return {

src/plugins/buttons/magic-attack.plugin.ts

@@ -7,19 +7,20 @@ import { gfxIds } from '@engine/world/config/gfx-ids';
 import { loopingEvent } from '@engine/game-server';
 import { TaskExecutor } from '@engine/world/action';
 import { widgetButtonIds } from '../skills/smithing/smelting-constants';
-import { magic_on_npcActionHandler, Magic_on_NPCActionHook, Magic_on_NPCAction } from '../../game-engine/world/action/magic-on-npc.action';
+import { magic_on_npcActionHandler, Magic_On_NPCActionHook, Magic_On_NPCAction } from '../../game-engine/world/action/magic-on-npc.action';
+import { logger } from '@runejs/core';
 
 const buttonIds: number[] = [
     0, // Home Teleport
 ];
 
 function attack_target(player: Player, elapsedTicks: number): boolean {
-    console.log("attacking?");
+    logger.info("attacking?");
     return true;
 }
 
 const spells = ["Wind Strike","Confuse", "Water Strike","unknown?", "Earth Strike"];
-export const activate = (task: TaskExecutor<Magic_on_NPCAction>, elapsedTicks: number = 0) => {
+export const activate = (task: TaskExecutor<Magic_On_NPCAction>, elapsedTicks: number = 0) => {
     const {
         npc,
         player,
@@ -41,6 +42,6 @@ export default {
                 activate,
                 interval: 0
             }
-        } as Magic_on_NPCActionHook
+        } as Magic_On_NPCActionHook
 
 };