fix lint issues

Signed-off-by: Swapnanil Gupta <[email protected]>

Author: Swapnanil-Gupta

api/handlers/container/logs.go

@@ -23,7 +23,7 @@ import (
 func (h *handler) logs(w http.ResponseWriter, r *http.Request) {
 	// return early if neither stdout and stderr are set
 	stdout, stderr := httputils.BoolValue(r, "stdout"), httputils.BoolValue(r, "stderr")
-	if !(stdout || stderr) {
+	if !stdout && !stderr {
 		response.JSON(w, http.StatusBadRequest, response.NewErrorFromMsg(
 			"you must choose at least one stream"))
 		return

api/handlers/image/pull.go

@@ -57,7 +57,7 @@ func (h *handler) pull(w http.ResponseWriter, r *http.Request) {
 		streamWriter.WriteError(code, err)
 		return
 	}
-	streamWriter.Write([]byte(fmt.Sprintf("Pulled %s:%s\n", name, tag)))
+	fmt.Fprintf(streamWriter, "Pulled %s:%s\n", name, tag)
 }
 
 func handleUnsupportedParams(r *http.Request) []string {

internal/backend/builder.go

@@ -67,11 +67,10 @@ func (p platformParser) DefaultSpec() platforms.Platform {
 // Licensed under the Apache License, Version 2.0
 // NOTICE: https://github.com/containerd/nerdctl/blob/main/NOTICE
 
-// TODO: Make generateBuildctlArgs public in nerdctl library.
-// source: https://github.com/containerd/nerdctl/blob/ff9323859a8d7892d8d72380a17b99395ef9a516/pkg/cmd/builder/build.go.
-//
 //nolint:stylecheck // adding a todo for exposing env in nerdctl library
 func (w *NerdctlWrapper) RunBuild(ctx context.Context, client *containerd.Client, options types.BuilderBuildOptions, buildID string) error {
+	// TODO: Make generateBuildctlArgs public in nerdctl library.
+	// source: https://github.com/containerd/nerdctl/blob/ff9323859a8d7892d8d72380a17b99395ef9a516/pkg/cmd/builder/build.go.
 	buildctlBinary, buildctlArgs, needsLoading, metaFile, tags, cleanup, err := generateBuildctlArgs(ctx, client, options)
 	if err != nil {
 		return err
@@ -85,7 +84,7 @@ func (w *NerdctlWrapper) RunBuild(ctx context.Context, client *containerd.Client
 	buildctlCmd := exec.Command(buildctlBinary, buildctlArgs...)
 	buildctlCmd.Env = os.Environ()
 	buildctlCmd.Env = append(buildctlCmd.Env, fmt.Sprintf("FINCH_BUILD_ID=%s", buildID))
-	buildctlCmd.Env = append(buildctlCmd.Env, fmt.Sprintf("FINCH_CREDENTIAL_SOCKET=%s",config.GetCredentialAddr()))
+	buildctlCmd.Env = append(buildctlCmd.Env, fmt.Sprintf("FINCH_CREDENTIAL_SOCKET=%s", config.GetCredentialAddr()))
 
 	var buildctlStdout io.Reader
 	if needsLoading {

internal/service/builder/build.go

@@ -62,7 +62,7 @@ func (s *service) Build(ctx context.Context, options *ncTypes.BuilderBuildOption
 				return nil, err
 			}
 			result = append(result, types.BuildResult{ID: tagEvent.ID})
-			options.Stdout.Write([]byte(fmt.Sprintf("Successfully built %s\n", tagEvent.ID)))
+			fmt.Fprintf(options.Stdout, "Successfully built %s\n", tagEvent.ID)
 		}
 	}
 

internal/service/container/unpause.go

@@ -25,7 +25,7 @@ func (s *service) Unpause(ctx context.Context, cid string, options ncTypes.Conta
 	status := s.client.GetContainerStatus(ctx, cont)
 	if status != containerd.Paused {
 		//nolint:stylecheck // Maintaining Docker-compatible error message format
-		return errdefs.NewConflict(fmt.Errorf("Container %s is not paused", cid))
+		return errdefs.NewConflict(fmt.Errorf("container %s is not paused", cid))
 	}
 
 	err = s.nctlContainerSvc.UnpauseContainer(ctx, cid, options)

internal/service/distribution/distribution.go

@@ -111,9 +111,8 @@ func (s *service) Inspect(ctx context.Context, name string, ac *dockertypes.Auth
 	}
 
 	var platforms []ocispec.Platform
-	switch {
-	case desc.MediaType == ocispec.MediaTypeImageManifest ||
-		desc.MediaType == containerdimages.MediaTypeDockerSchema2Manifest:
+	switch desc.MediaType {
+	case ocispec.MediaTypeImageManifest, containerdimages.MediaTypeDockerSchema2Manifest:
 		var manifest ocispec.Manifest
 		if err := json.Unmarshal(res, &manifest); err != nil {
 			return nil, fmt.Errorf("failed to unmarshal manifest: %w", err)
@@ -145,8 +144,7 @@ func (s *service) Inspect(ctx context.Context, name string, ac *dockertypes.Auth
 		}
 
 		platforms = []ocispec.Platform{image.Platform}
-	case desc.MediaType == ocispec.MediaTypeImageIndex ||
-		desc.MediaType == containerdimages.MediaTypeDockerSchema2ManifestList:
+	case ocispec.MediaTypeImageIndex, containerdimages.MediaTypeDockerSchema2ManifestList:
 		var index ocispec.Index
 		if err := json.Unmarshal(res, &index); err != nil {
 			return nil, fmt.Errorf("failed to unmarshal index: %w", err)

internal/service/image/remove.go

@@ -19,7 +19,7 @@ func (s *service) Remove(ctx context.Context, name string, force bool) (deleted,
 		err = errdefs.NewNotFound(fmt.Errorf("no such image: %s", name))
 		return
 	}
-	if matchCount > 1 && !(force && uniqueCount == 1) {
+	if matchCount > 1 && (!force || uniqueCount != 1) {
 		err = errdefs.NewConflict(fmt.Errorf(
 			"unable to delete %s (must be forced) - image is referenced in multiple repositories", name))
 		return

pkg/utility/imageutility/utility.go

@@ -41,5 +41,5 @@ func Canonicalize(name, tag string) (string, error) {
 func refNeedsTag(ref reference.Reference) bool {
 	_, tagged := ref.(reference.Tagged)
 	_, digested := ref.(reference.Digested)
-	return !(tagged || digested)
+	return !tagged && !digested
 }