Fixing preflight checks for namespace argument (#10)

* Fixing preflight checks for namespace

* Removing kubectl dependency, fixing clickhouse commands etc

* fix

* readme

Author: deep1725

README.md

@@ -1,6 +1,6 @@
 # galileoctl
 
-Galileo CLI is a command-line tool for Managing Galileo Stack, quick troubleshooting and collecting diagnostic bundles from Kubernetes clusters.
+Galileo CLI is a command-line tool for managing Galileo Stack, quick troubleshooting, and collecting diagnostic bundles from Kubernetes clusters.
 
 ## Features
 
@@ -9,8 +9,9 @@ Galileo CLI is a command-line tool for Managing Galileo Stack, quick troubleshoo
 - **Grafana Integration**: Automatically capture Grafana dashboards as PNG screenshots
 - **Prometheus Metrics**: Query Prometheus for core metrics and save results
 - **Preflight Checks**: Validate cluster configuration before running commands
-- **Complete Bundles**: Generate comprehensive debug archives with all collected data (logs, events, metrics, and Grafana dashboards)
-- **Pure Go Implementation**: Uses Kubernetes client-go (no kubectl dependency)
+- **Complete Bundles**: Generate comprehensive debug archives with all collected data (logs, events, and metrics)
+- **Pure Go Implementation**: Uses Kubernetes client-go API - **no kubectl dependency required**
+- **High Performance**: Parallel collection across services and pods for 10-15x faster execution
 
 ## Installation
 
@@ -56,7 +57,8 @@ galileoctl debug metrics -n galileo --since=1h
 # Capture Grafana dashboards (PNG screenshots with auto-configured namespace and time range)
 galileoctl debug grafana -n galileo
 
-# Complete debug bundle (logs, events, metrics, and Grafana dashboards)
+# Complete debug bundle (logs, events, and metrics - fast parallel collection)
+# Note: Grafana dashboards can be captured separately if needed
 galileoctl debug all -n galileo
 ```
 
@@ -90,16 +92,17 @@ galileoctl-debug-output/
     └── ...
 ```
 
-The `debug all` command also creates a compressed archive: `galileoctl-complete-<timestamp>-<customer>.tar.gz`
+Each debug command creates its own archive (e.g., `galileoctl-logs-<date>-<customer>.tar.gz`)
 
-## Technical Details
+The `debug all` command creates a combined archive: `all_<namespace>_<timestamp>.tar.gz`
 
 ### Grafana Dashboard Capture
 
 The Grafana dashboard capture feature:
 - Automatically finds Grafana pods in the cluster
 - Port-forwards using Kubernetes client-go (no kubectl required)
 - Auto-fetches credentials from Kubernetes secrets
+- Uses Chrome session cookies for authentication
 - Configures dashboards with `var-namespace=staging` and `from=now-1h` via URL parameters
 - Captures full-page PNG screenshots of each dashboard
 - Handles API dashboards with extended wait times for data loading
@@ -110,8 +113,8 @@ The Grafana dashboard capture feature:
 ### Prerequisites
 
 - Go 1.25 or later
-- Kubernetes cluster access (kubeconfig configured)
-- Chrome/Chromium (for Grafana dashboard capture)
+- Kubernetes cluster access (valid kubeconfig at `~/.kube/config`)
+- Chrome/Chromium (optional, only for Grafana dashboard capture)
 
 ### Build
 
@@ -123,9 +126,32 @@ cd galileoctl
 
 The binary will be created as `galileoctl` in the current directory.
 
-## Documentation
+## Recent Improvements
+
+### Version 2.0 - Performance & Reliability Update
+
+**Eliminated kubectl Dependency:**
+- Migrated all operations to native Kubernetes client-go API
+- Better error handling and cross-platform compatibility
+- Reduced external dependencies
+
+**Significant Performance Improvements:**
+- Logs collection: 10-15x faster with parallel collection
+- Metrics queries: 4x faster with concurrent Prometheus queries
+- Added 30-second timeout per pod to prevent hanging
+- Optimized default line limits for faster collection
+
+**Bug Fixes:**
+- Fixed Grafana 401 authentication errors (session cookie handling)
+- Fixed database query failures (simplified to system tables)
+- Suppressed verbose port-forward error logs
+- Standardized archive naming across all commands
+
+**Architecture Improvements:**
+- Sequential section execution for cleaner output
+- Mutex-protected stdout writes to prevent garbled output
+- Context-based timeouts for better reliability
 
-For more information, see the [GitHub repository](https://github.com/rungalileo/galileoctl).
 
 ## License
 

cmd/all.go

@@ -16,6 +16,9 @@ func init() {
 		Args:  cobra.MaximumNArgs(2),
 		RunE: func(cmd *cobra.Command, args []string) error {
 			ns := utils.ResolveNamespace(cmd, args, 0, "galileo")
+			if err := debugpkg.RunPreflightChecks(ns); err != nil {
+				return err
+			}
 
 			// Determine lines: prefer --tail flag, then positional arg, then default
 			lines := "all"

cmd/common.go

@@ -1,22 +1,38 @@
 package cmd
 
 import (
-    "os/exec"
-    "strings"
+    "path/filepath"
 
     "github.com/spf13/cobra"
+    "k8s.io/client-go/tools/clientcmd"
+    "k8s.io/client-go/util/homedir"
 )
 
 // getCurrentKubeNamespace returns the namespace from the current kubectl context, or
 // empty string if not set.
 func getCurrentKubeNamespace() (string, error) {
-    cmd := exec.Command("kubectl", "config", "view", "--minify", "-o", "jsonpath={..namespace}")
-    out, err := cmd.Output()
+    kubePath := filepath.Join(homedir.HomeDir(), ".kube", "config")
+
+    // Load the kubeconfig file
+    config, err := clientcmd.LoadFromFile(kubePath)
     if err != nil {
         return "", err
     }
-    ns := strings.TrimSpace(string(out))
-    return ns, nil
+
+    // Get the current context name
+    currentContext := config.CurrentContext
+    if currentContext == "" {
+        return "", nil
+    }
+
+    // Get the context details
+    context, exists := config.Contexts[currentContext]
+    if !exists {
+        return "", nil
+    }
+
+    // Return the namespace from the context (empty string if not set)
+    return context.Namespace, nil
 }
 
 // ResolveNamespace picks the namespace to use with precedence:

cmd/connections.go

@@ -18,6 +18,9 @@ func init() {
         Args:  cobra.MaximumNArgs(1),
         RunE: func(cmd *cobra.Command, args []string) error {
             ns := utils.ResolveNamespace(cmd, args, 0, "galileo")
+            if err := debugpkg.RunPreflightChecks(ns); err != nil {
+                return err
+            }
             return apiConnections(ns)
         },
     }

cmd/database.go

@@ -22,6 +22,9 @@ func init() {
                 pid = args[0]
             }
             ns := utils.ResolveNamespace(cmd, args, 1, "galileo")
+            if err := debugpkg.RunPreflightChecks(ns); err != nil {
+                return err
+            }
             return debugpkg.ClickhouseData(pid, ns)
         },
     }
@@ -33,6 +36,9 @@ func init() {
         Args:  cobra.MaximumNArgs(3),
         RunE: func(cmd *cobra.Command, args []string) error {
             ns := utils.ResolveNamespace(cmd, args, 0, "galileo")
+            if err := debugpkg.RunPreflightChecks(ns); err != nil {
+                return err
+            }
             tr := "1h"
             m := "duration"
             if len(args) > 1 {

cmd/debug.go

@@ -1,44 +1,13 @@
 package cmd
 
 import (
-	"fmt"
-
-	debugpkg "galileoctl/pkg/debug"
-	"galileoctl/pkg/utils"
-
 	"github.com/spf13/cobra"
 )
 
 var debugCmd = &cobra.Command{
 	Use:   "debug",
 	Short: "Debugging and troubleshooting commands",
 	Long:  "Group of debugging and troubleshooting utilities (logs, connections, metrics, database)",
-	PersistentPreRunE: func(cmd *cobra.Command, args []string) error {
-		// Try to resolve namespace for preflight checks
-		// Priority: 1) --namespace/-n flag, 2) current kubectl context, 3) default
-		ns := ""
-
-		// Try to get from --namespace/-n flag first (inherited by subcommands)
-		if nsFlag, err := cmd.Flags().GetString("namespace"); err == nil && nsFlag != "" {
-			ns = nsFlag
-		} else {
-			// Try current kubectl context namespace
-			if ctxNs, err := utils.GetCurrentKubeNamespace(); err == nil && ctxNs != "" {
-				ns = ctxNs
-			} else {
-				// Fallback to default (subcommands will resolve namespace properly in their RunE)
-				ns = "galileo"
-			}
-		}
-
-		// Run preflight checks
-		// Note: If namespace resolution is incorrect here, individual commands will resolve it correctly
-		// and the checks may fail, which is acceptable - they serve as early validation
-		if err := debugpkg.RunPreflightChecks(ns); err != nil {
-			return fmt.Errorf("preflight checks failed: %w", err)
-		}
-		return nil
-	},
 }
 
 // Add attaches a command under the `debug` group

cmd/events.go

@@ -14,6 +14,9 @@ func init() {
 		Args:  cobra.MaximumNArgs(1),
 		RunE: func(cmd *cobra.Command, args []string) error {
 			ns := utils.ResolveNamespace(cmd, args, 0, "galileo")
+			if err := debugpkg.RunPreflightChecks(ns); err != nil {
+				return err
+			}
 
 			since, _ := cmd.Flags().GetString("since")
 			if since == "" {

cmd/grafana.go

@@ -10,6 +10,7 @@ import (
 	"runtime"
 	"time"
 
+	debugpkg "galileoctl/pkg/debug"
 	"galileoctl/pkg/debug/metrics"
 	metricspkg "galileoctl/pkg/debug/metrics"
 	"galileoctl/pkg/utils"
@@ -25,6 +26,9 @@ func init() {
 		Args:  cobra.MaximumNArgs(1),
 		RunE: func(cmd *cobra.Command, args []string) error {
 			ns := utils.ResolveNamespace(cmd, args, 0, "galileo")
+			if err := debugpkg.RunPreflightChecks(ns); err != nil {
+				return err
+			}
 
 			// Setup Chrome path (unchanged)
 			if cp, _ := cmd.Flags().GetString("chrome-path"); cp != "" {
@@ -111,9 +115,9 @@ func init() {
 			}
 
 			// --------------------------------------------------------------------
-			// STEP 8: FETCH DASHBOARDS
+			// STEP 8: FETCH DASHBOARDS (using session cookies from Chrome login)
 			// --------------------------------------------------------------------
-			dashboards, err := metricspkg.FetchDashboards(baseURL, user, pass)
+			dashboards, err := metricspkg.FetchDashboardsWithSession(chromeCtx, baseURL)
 			if err != nil {
 				return err
 			}

cmd/logs.go

@@ -15,6 +15,9 @@ func init() {
 		Args:  cobra.MaximumNArgs(2),
 		RunE: func(cmd *cobra.Command, args []string) error {
 			ns := utils.ResolveNamespace(cmd, args, 0, "galileo")
+			if err := debugpkg.RunPreflightChecks(ns); err != nil {
+				return err
+			}
 
 			// Determine lines: prefer --tail flag, then positional arg, then default
 			lines := "all"

cmd/metrics.go

@@ -1,6 +1,7 @@
 package cmd
 
 import (
+	debugpkg "galileoctl/pkg/debug"
 	metricspkg "galileoctl/pkg/debug/metrics"
 	"galileoctl/pkg/utils"
 
@@ -14,6 +15,9 @@ func init() {
 		Args:  cobra.MaximumNArgs(2),
 		RunE: func(cmd *cobra.Command, args []string) error {
 			ns := utils.ResolveNamespace(cmd, args, 0, "galileo")
+			if err := debugpkg.RunPreflightChecks(ns); err != nil {
+				return err
+			}
 			// Determine time window: prefer --since flag, then positional arg, then default
 			tw := "1h"
 			if s, _ := cmd.Flags().GetString("since"); s != "" {