Skip to content

Commit 0ba6760

Browse files
authored
Merge pull request #947 from lyp000119/dev
fix: Start to analyze the page drag and drop field has a cache problem
2 parents 8c12092 + fd6ba60 commit 0ba6760

File tree

2 files changed

+25
-15
lines changed

2 files changed

+25
-15
lines changed

frontend/src/app/pages/ChartWorkbenchPage/components/ChartOperationPanel/components/ChartDraggable/ChartDraggableSourceContainer.tsx

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,11 @@ import {
4242
FONT_WEIGHT_MEDIUM,
4343
INFO,
4444
SPACE,
45-
SPACE_SM,
4645
SPACE_TIMES,
4746
SUCCESS,
4847
WARNING,
4948
} from 'styles/StyleConstants';
49+
import { stopPPG } from 'utils/utils';
5050

5151
export const ChartDraggableSourceContainer: FC<
5252
{
@@ -159,18 +159,20 @@ export const ChartDraggableSourceContainer: FC<
159159
<>
160160
<IW fontSize={FONT_SIZE_HEADING}>{icon}</IW>
161161
<p>{colName}</p>
162-
<Dropdown
163-
disabled={_isNormalField()}
164-
overlay={_getExtraActionMenus()}
165-
trigger={['click']}
166-
>
167-
<ToolbarButton
168-
icon={<MoreOutlined />}
169-
iconSize={FONT_SIZE_BASE}
170-
className="setting"
171-
onClick={e => e.preventDefault()}
172-
/>
173-
</Dropdown>
162+
<div onClick={stopPPG}>
163+
<Dropdown
164+
disabled={_isNormalField()}
165+
overlay={_getExtraActionMenus()}
166+
trigger={['click']}
167+
>
168+
<ToolbarButton
169+
icon={<MoreOutlined />}
170+
iconSize={FONT_SIZE_BASE}
171+
className="setting"
172+
onClick={e => e.preventDefault()}
173+
/>
174+
</Dropdown>
175+
</div>
174176
</>
175177
);
176178
}, [type, colName, onDeleteComputedField, onEditComputedField, category, t]);

frontend/src/app/pages/ChartWorkbenchPage/components/ChartOperationPanel/components/ChartDraggable/ChartDraggableSourceGroupContainer.tsx

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
import { List } from 'antd';
2020
import { ChartDataViewMeta } from 'app/types/ChartDataViewMeta';
21-
import { FC, memo, useState } from 'react';
21+
import { FC, memo, useCallback, useState } from 'react';
2222
import styled from 'styled-components/macro';
2323
import { stopPPG } from 'utils/utils';
2424
import { ChartDraggableSourceContainer } from './ChartDraggableSourceContainer';
@@ -91,6 +91,14 @@ export const ChartDraggableSourceGroupContainer: FC<{
9191
}
9292
};
9393

94+
const handleEditComputedField = useCallback(
95+
fieldName => {
96+
onEditComputedField(fieldName);
97+
setSelectedItems([]);
98+
},
99+
[onEditComputedField],
100+
);
101+
94102
return (
95103
<Container onClick={onClearCheckedList}>
96104
{/* 拖动层组件 */}
@@ -108,7 +116,7 @@ export const ChartDraggableSourceGroupContainer: FC<{
108116
expression={item.expression}
109117
type={item.type}
110118
onDeleteComputedField={onDeleteComputedField}
111-
onEditComputedField={onEditComputedField}
119+
onEditComputedField={handleEditComputedField}
112120
onSelectionChange={onDataItemSelectionChange}
113121
onClearCheckedList={onClearCheckedList}
114122
isActive={selectedItemsIds.includes(item.id)}

0 commit comments

Comments
 (0)