Skip to content

Commit 47f51a1

Browse files
committed
fix: Delete clone and change to destructuring assignment
1 parent f632606 commit 47f51a1

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

frontend/src/app/pages/ChartWorkbenchPage/slice/workbenchSlice.ts

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ import { RootState } from 'types';
4646
import { useInjectReducer } from 'utils/@reduxjs/injectReducer';
4747
import { isMySliceRejectedAction } from 'utils/@reduxjs/toolkit';
4848
import { rejectedActionMessageHandler } from 'utils/notification';
49-
import { CloneValueDeep } from 'utils/object';
5049
import { request2 } from 'utils/request';
5150
import { listToTree, rejectHandle } from 'utils/utils';
5251
import { ChartDTO } from '../../../types/ChartDTO';
@@ -460,20 +459,18 @@ const workbenchSlice = createSlice({
460459
state.dataviews = payload;
461460
})
462461
.addCase(fetchViewDetailAction.fulfilled, (state, { payload }) => {
463-
let viewData = CloneValueDeep(payload);
464462
const index = state.dataviews?.findIndex(
465-
view => view.id === viewData.id,
463+
view => view.id === payload.id,
466464
);
467465
let computedFields: ChartDataViewMeta[] = [];
468-
if (viewData.id === state?.backendChart?.view?.id) {
466+
if (payload.id === state?.backendChart?.view?.id) {
469467
computedFields = state?.backendChart?.config?.computedFields || [];
470468
}
471469

472470
if (index !== undefined) {
473-
viewData.config = migrateViewConfig(viewData.config);
474471
state.currentDataView = {
475-
...viewData,
476-
meta: transformMeta(viewData.model),
472+
...{ ...payload, config: migrateViewConfig(payload.config) },
473+
meta: transformMeta(payload.model),
477474
computedFields,
478475
};
479476
}

0 commit comments

Comments
 (0)