Skip to content

Commit 97287ed

Browse files
committed
refactor: selectDrillStatusMenu
1 parent efce237 commit 97287ed

File tree

1 file changed

+24
-16
lines changed

1 file changed

+24
-16
lines changed

frontend/src/app/components/ChartDrill/ChartDrillContextMenu.tsx

Lines changed: 24 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,22 @@ const ChartDrillContextMenu: FC<{}> = memo(({ children }) => {
3131
const { drillOption, onDrillOptionChange } = useContext(ChartDrillContext);
3232

3333
const currentDrillLevel = drillOption?.getCurrentDrillLevel();
34-
34+
const selectDrillStatusMenu = useMemo(() => {
35+
return (
36+
<Menu.Item key="selectDrillStatus">
37+
<StyledMenuSwitch
38+
className={classnames({ on: !!drillOption?.isSelectedDrill })}
39+
>
40+
<p>
41+
{drillOption?.isSelectedDrill
42+
? t('selectDrillOn')
43+
: t('selectDrillOff')}
44+
</p>
45+
<CheckOutlined className="icon" />
46+
</StyledMenuSwitch>
47+
</Menu.Item>
48+
);
49+
}, [drillOption?.isSelectedDrill, t]);
3550
const contextMenu = useMemo(() => {
3651
return (
3752
<StyledChartDrillMenu
@@ -65,23 +80,16 @@ const ChartDrillContextMenu: FC<{}> = memo(({ children }) => {
6580
!drillOption?.isBottomLevel && (
6681
<Menu.Item key={DrillMode.Expand}>{t('expandNextLevel')}</Menu.Item>
6782
)}
68-
{drillOption?.mode !== DrillMode.Expand && (
69-
<Menu.Item key="selectDrillStatus">
70-
<StyledMenuSwitch
71-
className={classnames({ on: !!drillOption?.isSelectedDrill })}
72-
>
73-
<p>
74-
{drillOption?.isSelectedDrill
75-
? t('selectDrillOn')
76-
: t('selectDrillOff')}
77-
</p>
78-
<CheckOutlined className="icon" />
79-
</StyledMenuSwitch>
80-
</Menu.Item>
81-
)}
83+
{drillOption?.mode !== DrillMode.Expand && selectDrillStatusMenu}
8284
</StyledChartDrillMenu>
8385
);
84-
}, [drillOption, currentDrillLevel, t, onDrillOptionChange]);
86+
}, [
87+
currentDrillLevel,
88+
t,
89+
drillOption,
90+
selectDrillStatusMenu,
91+
onDrillOptionChange,
92+
]);
8593

8694
return (
8795
<StyledChartDrill className="chart-drill-menu-container">

0 commit comments

Comments
 (0)