Skip to content

Commit 9a04335

Browse files
authored
Merge pull request #1223 from Cuiyansong/master
refactor(chart): refactor chart drill path style
2 parents 74fa460 + c18503e commit 9a04335

File tree

4 files changed

+10
-4
lines changed

4 files changed

+10
-4
lines changed

frontend/src/app/components/ChartEditor.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ export const ChartEditor: FC<ChartEditorProps> = ({
297297
}),
298298
);
299299
drillOptionRef.current = getChartDrillOption(
300-
chartConfig?.datas,
300+
finalChartConfig?.datas,
301301
drillOptionRef.current,
302302
);
303303
if (!expensiveQuery) {

frontend/src/app/pages/ChartWorkbenchPage/components/ChartOperationPanel/components/ChartPresentPanel/ChartPresentPanel.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ import ChartTypeSelector, {
4545
} from './components/ChartTypeSelector';
4646

4747
const CHART_TYPE_SELECTOR_HEIGHT_OFFSET = 50;
48-
const CHART_DRILL_PATH_HEIGHT = 24;
48+
const CHART_DRILL_PATH_HEIGHT = 40;
4949

5050
const ChartPresentPanel: FC<{
5151
containerHeight?: number;

frontend/src/app/pages/MainPage/pages/VizPage/ChartPreview/ChartPreview.tsx

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -418,7 +418,10 @@ const ChartPreviewBoard: FC<{
418418
</ChartDrillContextMenu>
419419
</Spin>
420420
</ChartWrapper>
421-
<ChartDrillPaths />
421+
<StyledChartDrillPathsContainer>
422+
<ChartDrillPaths />
423+
</StyledChartDrillPathsContainer>
424+
<StyledChartDrillPathsContainer />
422425
</ChartDrillContext.Provider>
423426
</PreviewBlock>
424427
</StyledChartPreviewBoard>
@@ -464,3 +467,7 @@ const ChartWrapper = styled.div`
464467
}
465468
}
466469
`;
470+
471+
const StyledChartDrillPathsContainer = styled.div`
472+
background-color: ${p => p.theme.componentBackground};
473+
`;

frontend/src/app/pages/SharePage/ChartForShare.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,6 @@ const ChartForShare: FC<{
176176
</div>
177177
<ChartDrillPaths />
178178
</ChartDrillContext.Provider>
179-
<ChartDrillPaths />
180179
<HeadlessBrowserIdentifier
181180
renderSign={headlessBrowserRenderSign}
182181
width={Number(width) || 0}

0 commit comments

Comments
 (0)