Start eth_sign implementation (#438)

* Start eth_sign implementation

* Update eth_sign to new event loop convention

* Draft a proper implementation of #privateKey

* Fix build-node error

* Change storage configuration of account keys

* Check for nonexistent account in eth_sign call

* web3: more specific error message

Author: gtrepta

Makefile

@@ -278,7 +278,7 @@ $(DEFN_DIR)/ocaml/$(MAIN_DEFN_FILE)-kompiled/plugin/semantics.$(LIBEXT): $(wildc
 	    && cd $(dir $@) \
 	        && ocamlfind $(OCAMLC) -c -g -I $(CURDIR)/$(DEFN_DIR)/ocaml/$(MAIN_DEFN_FILE)-kompiled \
 	                               KRYPTO.ml \
-	                               -package cryptokit -package secp256k1 -package bn128 -package ocaml-protoc -safe-string -thread \
+	                               -package cryptokit -package hex -package secp256k1 -package bn128 -package ocaml-protoc -safe-string -thread \
 	        && ocamlfind $(OCAMLC) -a -o semantics.$(LIBEXT) KRYPTO.$(EXT) -thread \
 	        && ocamlfind remove ethereum-semantics-plugin-ocaml \
 	        && ocamlfind install ethereum-semantics-plugin-ocaml $(PLUGIN_SUBMODULE)/plugin/META semantics.* *.cmi *.$(EXT)
@@ -292,7 +292,7 @@ $(DEFN_DIR)/ocaml/$(MAIN_DEFN_FILE)-kompiled/interpreter: $(DEFN_DIR)/ocaml/$(MA
 	        && ocamlfind $(OCAMLC) -c -g -w -11-26 -package gmp -package zarith -package uuidm -package ethereum-semantics-plugin-ocaml -safe-string realdef.ml -match-context-rows 2 \
 	        && ocamlfind $(OCAMLC) $(LIBFLAG) -o realdef.$(DLLEXT) realdef.$(EXT) \
 	        && ocamlfind $(OCAMLC) -g -o interpreter constants.$(EXT) prelude.$(EXT) plugin.$(EXT) parser.$(EXT) lexer.$(EXT) hooks.$(EXT) run.$(EXT) interpreter.ml \
-	                               -package gmp -package dynlink -package zarith -package str -package uuidm -package unix -package ethereum-semantics-plugin-ocaml -linkpkg -linkall -thread -safe-string
+	                               -package gmp -package hex -package dynlink -package zarith -package str -package uuidm -package unix -package ethereum-semantics-plugin-ocaml -linkpkg -linkall -thread -safe-string
 
 # Node Backend
 

deps/plugin

@@ -14,6 +14,7 @@ module KRYPTO
 -   `Sha256` takes a String and returns a 64-character hex-encoded string of the 32-byte SHA2-256 hash of the string.
 -   `RipEmd160` takes a String and returns a 40-character hex-encoded string of the 20-byte RIPEMD160 hash of the string.
 -   `ECDSARecover` takes a 32-character byte string of a message, v, r, s of the signed message and returns the 64-character public key used to sign the message.
+-   `ECDSASign` takes a 32-character byte string of a message hash, a 32-character byte string of a private key, and returns the 65 byte hex-encoded signature in [r,s,v] form
     See [this StackOverflow post](https://ethereum.stackexchange.com/questions/15766/what-does-v-r-s-in-eth-gettransactionbyhash-mean) for some information about v, r, and s.
 
 In all functions above, input `String` is interpreted as byte array, e.g. it is NOT hex-encoded.
@@ -23,6 +24,7 @@ In all functions above, input `String` is interpreted as byte array, e.g. it is
                     | ECDSARecover ( String , Int , String , String ) [function, hook(KRYPTO.ecdsaRecover)]
                     | Sha256 ( String )                               [function, hook(KRYPTO.sha256)]
                     | RipEmd160 ( String )                            [function, hook(KRYPTO.ripemd160)]
+                    | ECDSASign ( String, String )                    [function, hook(KRYPTO.ecdsaSign)]
  // ----------------------------------------------------------------------------------------------------
 ```
 

krypto.md

@@ -15,6 +15,7 @@ module WEB3
         <blockchain>
           <chainID> $CHAINID:Int </chainID>
         </blockchain>
+        <accountKeys> .Map </accountKeys>
         <snapshots> .List </snapshots> 
         <web3socket> $SOCK:Int </web3socket>
         <web3clientsocket> 0:IOInt </web3clientsocket>
@@ -161,6 +162,8 @@ module WEB3
          <method> "eth_getStorageAt" </method>
     rule <k> #runRPCCall => #eth_getCode ... </k>
          <method> "eth_getCode" </method>
+    rule <k> #runRPCCall => #eth_sign ... </k>
+         <method> "eth_sign" </method>
     rule <k> #runRPCCall => #evm_snapshot ... </k>
          <method> "evm_snapshot" </method>
     rule <k> #runRPCCall => #evm_revert ... </k>
@@ -238,6 +241,25 @@ module WEB3
            ...
          </account>
 
+    syntax KItem ::= "#eth_sign"
+ // ----------------------------
+    rule <k> #eth_sign => #signMessage(KEY, #hashMessage(#unparseByteStack(#parseByteStack(MESSAGE)))) ... </k>
+         <params> [ ACCTADDR, MESSAGE, .JSONList ] </params>
+         <accountKeys>... #parseHexWord(ACCTADDR) |-> KEY ...</accountKeys>
+
+    rule <k> #eth_sign => #sendResponse( "error": {"code": 3, "message": "Execution error", "data": [{ "code": 100, "message": "Account key doesn't exist, account locked!" }]} ) ... </k>
+         <params> [ ACCTADDR, _ ] </params>
+         <accountKeys> KEYMAP </accountKeys>
+      requires notBool #parseHexWord(ACCTADDR) in_keys(KEYMAP)
+
+    syntax KItem ::= #signMessage ( String , String )
+ // -------------------------------------------------
+    rule <k> #signMessage(KEY, MHASH) => #sendResponse( "result" : "0x" +String ECDSASign( MHASH, KEY ) ) ... </k>
+
+    syntax String ::= #hashMessage ( String ) [function]
+ // ----------------------------------------------------
+    rule #hashMessage( S ) => #unparseByteStack(#parseHexBytes(Keccak256("\x19Ethereum Signed Message:\n" +String Int2String(lengthString(S)) +String S)))
+
     syntax KItem ::= "#evm_snapshot"
  // --------------------------------
     rule <k> #evm_snapshot => #pushNetworkState ~> #sendResponse( "result" : #unparseQuantity( size ( SNAPSHOTS ) ) ) ... </k>