Changelog #157

Author: lnicola

generated_assists.adoc

@@ -728,7 +728,7 @@ fn qux(bar: Bar, baz: Baz) {}
 
 [discrete]
 === `extract_function`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/extract_function.rs#L36[extract_function.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/extract_function.rs#L38[extract_function.rs]
 
 Extracts selected statements and comments into new function.
 
@@ -1433,14 +1433,14 @@ impl Person {
 
 [discrete]
 === `generate_impl`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/generate_impl.rs#L5[generate_impl.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/generate_impl.rs#L8[generate_impl.rs]
 
 Adds a new inherent impl for a type.
 
 .Before
 ```rust
-struct Ctx<T: Clone> {
-    data: T,┃
+struct Ctx┃<T: Clone> {
+    data: T,
 }
 ```
 
@@ -1544,6 +1544,31 @@ impl Person {
 ```
 
 
+[discrete]
+=== `generate_trait_impl`
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/generate_impl.rs#L56[generate_impl.rs]
+
+Adds a new trait impl for a type.
+
+.Before
+```rust
+struct ┃Ctx<T: Clone> {
+    data: T,
+}
+```
+
+.After
+```rust
+struct Ctx<T: Clone> {
+    data: T,
+}
+
+impl<T: Clone> ┃ for Ctx<T> {
+
+}
+```
+
+
 [discrete]
 === `inline_call`
 **Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/inline_call.rs#L161[inline_call.rs]

generated_config.adoc

@@ -190,7 +190,7 @@ cargo check --workspace --message-format=json --all-targets
 ```
 .
 --
-[[rust-analyzer.checkOnSave.target]]rust-analyzer.checkOnSave.target (default: `[]`)::
+[[rust-analyzer.checkOnSave.target]]rust-analyzer.checkOnSave.target (default: `null`)::
 +
 --
 Check for specific targets. Defaults to `#rust-analyzer.cargo.target#` if empty.

generated_features.adoc

@@ -264,12 +264,13 @@ image::https://user-images.githubusercontent.com/48062697/113020656-b560f500-917
 
 
 === Go to Declaration
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide/src/goto_declaration.rs#L10[goto_declaration.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide/src/goto_declaration.rs#L13[goto_declaration.rs]
 
 Navigates to the declaration of an identifier.
 
-This is currently the same as `Go to Definition` with the exception of outline modules where it
-will navigate to the `mod name;` item declaration.
+This is the same as `Go to Definition` with the following exceptions:
+- outline modules will navigate to the `mod name;` item declaration
+- trait assoc items will navigate to the assoc item of the trait declaration opposed to the trait impl
 
 
 === Go to Definition

thisweek/_posts/2022-11-21-changelog-156.adoc

@@ -12,7 +12,7 @@ Release: release:2022-11-21[]
 image::https://user-images.githubusercontent.com/7951708/192122707-7a00606a-e581-4534-b9d5-b81c92694e8e.png["Screenshot showing an editor highlighting two warnings in code gated for different targets on one side and the `cargo check` output on the other side, with the same warnings. It also shows how to configure multiple targets as a `build.target` array in `.cargo/config.toml`."]
 * pr:13633[] allow viewing the full compiler diagnostic in a readonly textview:
 +
-image::https://user-images.githubusercontent.com/3757771/202780459-f751f65d-2b1b-4dc3-9685-100d65ebf6a0.gif["Screen case showing  a compilation error in VS Code. The diagnostics pop-up has a `Click here for full compiler diagnostic` link which, when clicked, displays the `rustc` output in another tab, including the ASCII art showing the various spans of the error."]
+image::https://user-images.githubusercontent.com/3757771/202780459-f751f65d-2b1b-4dc3-9685-100d65ebf6a0.gif["Screen cast showing  a compilation error in VS Code. The diagnostics pop-up has a `Click here for full compiler diagnostic` link which, when clicked, displays the `rustc` output in another tab, including the ASCII art showing the various spans of the error."]
 * pr:13629[] make "Remove ``dbg!()``" work on selections.
 
 == Fixes

thisweek/_posts/2022-11-28-changelog-157.adoc

@@ -0,0 +1,31 @@
+= Changelog #157
+:sectanchors:
+:page-layout: post
+
+Commit: commit:6d61be8e65ac0fd45eaf178e1f7a1ec6b582de1f[] +
+Release: release:2022-11-28[]
+
+== New Features
+
+* pr:13592[] (first contribution) add "Generate trait impl" assist.
+* pr:13638[] add hover hint to `..` in record patterns:
++
+image::https://user-images.githubusercontent.com/51814158/202837115-f424cc26-c2d7-4027-8eea-eeb7749ad146.png["Screenshot showing a hover tooltip with the missing fields over a `..` in a record pattern"]
+
+== Fixes
+
+* pr:13576[] (first contribution) suppress "Implement default members" inside contained items.
+* pr:13661[] (first contribution) handle empty `checkOnSave.targets` values.
+* pr:13647[] (first contribution) fix tuple to named struct conversion inside macro calls.
+* pr:13652[] unquote strings in `compile_error!` expansions.
+* pr:13667[] handle sysroot config in detached-files workspaces.
+* pr:13670[] add `deriveHelper` to the `semanticTokenTypes` section of `package.json`.
+* pr:13611[] don't trigger completions after single colon.
+* pr:13671[] improve Go to declaration.
+* pr:13681[] check tail expressions more precisely in "Extract function".
+
+== Internal Improvements
+
+* pr:13678[] reduce the size of `HirFileId` from 8 to 4 bytes.
+* pr:13676[] mega-sync from `rust-lang/rust`.
+* pr:13669[] properly implement `Drop` for `JodGroupChild`.