Changelog #154

Author: lnicola

generated_assists.adoc

@@ -23,7 +23,7 @@ fn main() {
 
 [discrete]
 === `add_hash`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/raw_string.rs#L91[raw_string.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/raw_string.rs#L88[raw_string.rs]
 
 Adds a hash to a raw string literal.
 
@@ -477,6 +477,30 @@ fn main() {
 ```
 
 
+[discrete]
+=== `convert_match_to_let_else`
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/convert_match_to_let_else.rs#L12[convert_match_to_let_else.rs]
+
+Converts let statement with match initializer to let-else statement.
+
+.Before
+```rust
+fn foo(opt: Option<()>) {
+    let val = ┃match opt {
+        Some(it) => it,
+        None => return,
+    };
+}
+```
+
+.After
+```rust
+fn foo(opt: Option<()>) {
+    let Some(val) = opt else { return };
+}
+```
+
+
 [discrete]
 === `convert_named_struct_to_tuple_struct`
 **Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/convert_named_struct_to_tuple_struct.rs#L11[convert_named_struct_to_tuple_struct.rs]
@@ -788,7 +812,7 @@ enum A { One(One) }
 
 [discrete]
 === `extract_type_alias`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/extract_type_alias.rs#L11[extract_type_alias.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/extract_type_alias.rs#L10[extract_type_alias.rs]
 
 Extracts the selected type as a type alias.
 
@@ -1522,7 +1546,7 @@ impl Person {
 
 [discrete]
 === `inline_call`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/inline_call.rs#L159[inline_call.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/inline_call.rs#L161[inline_call.rs]
 
 Inlines a function or method body creating a `let` statement per parameter unless the parameter
 can be inlined. The parameter will be inlined either if it the supplied argument is a simple local
@@ -1548,7 +1572,7 @@ fn foo(name: Option<&str>) {
 
 [discrete]
 === `inline_into_callers`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/inline_call.rs#L25[inline_call.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/inline_call.rs#L27[inline_call.rs]
 
 Inline a function or method body into all of its callers where possible, creating a `let` statement per parameter
 unless the parameter can be inlined. The parameter will be inlined either if it the supplied argument is a simple local
@@ -1778,7 +1802,7 @@ fn main() {
 
 [discrete]
 === `make_usual_string`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/raw_string.rs#L49[raw_string.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/raw_string.rs#L46[raw_string.rs]
 
 Turns a raw string into a plain string.
 
@@ -2183,7 +2207,7 @@ fn main() {
 
 [discrete]
 === `remove_hash`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/raw_string.rs#L119[raw_string.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/raw_string.rs#L116[raw_string.rs]
 
 Removes a hash from a raw string literal.
 

generated_config.adoc

@@ -1,3 +1,9 @@
+[[rust-analyzer.assist.emitMustUse]]rust-analyzer.assist.emitMustUse (default: `false`)::
++
+--
+Whether to insert #[must_use] when generating `as_` methods
+for enum variants.
+--
 [[rust-analyzer.assist.expressionFillDefault]]rust-analyzer.assist.expressionFillDefault (default: `"todo"`)::
 +
 --

generated_features.adoc

@@ -572,7 +572,7 @@ The simplest way to use this feature is via the context menu:
 
 
 === Rename
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide/src/rename.rs#L65[rename.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide/src/rename.rs#L67[rename.rs]
 
 Renames the item below the cursor and all of its references
 

manual.adoc

@@ -487,6 +487,12 @@ https://docs.helix-editor.com/[Helix] supports LSP by default.
 However, it won't install `rust-analyzer` automatically.
 You can follow instructions for installing <<rust-analyzer-language-server-binary,`rust-analyzer` binary>>.
 
+=== Crates
+
+There is a package named `ra_ap_rust_analyzer` available on https://crates.io/crates/ra_ap_rust-analyzer[crates.io], for someone who wants to use it programmatically.
+
+For more details, see https://github.com/rust-lang/rust-analyzer/blob/master/.github/workflows/publish.yml[the publish workflow].
+
 == Troubleshooting
 
 Start with looking at the rust-analyzer version.

thisweek/_posts/2022-11-07-changelog-154.adoc

@@ -0,0 +1,56 @@
+= Changelog #154
+:sectanchors:
+:page-layout: post
+
+Commit: commit:d03c1c87d4ca2d524646316387d47b12524ac451[] +
+Release: release:2022-11-07[]
+
+== An Update on OpenVSX ==
+
+Many users of VS Code are actually running an open-source version of the editor.
+These include VSCodium and the `code` package in Arch Linux.
+The "free" builds are not allowed to connect to the Microsoft Marketplace and instead they download extensions from https://open-vsx.org[OpenVSX].
+
+For a long time, the version of rust-analyzer available on OpenVSX was outdated and did not work very well with recent Rust toolchains.
+But because of various technical reasons, we were not able to publish new versions there.
+This caused countless of disappointed users, and dozens of duplicate issues filed against our tracker.
+
+Last week, with the help of the OpenVSX maintainers, we managed to sort out the issues.
+And for the first time in almost a year, rust-analyzer is https://open-vsx.org/extension/rust-lang/rust-analyzer[available] on OpenVSX.
+Unfortunately, we had to remove the existing versions, under the identifier of `matklad.rust-analyzer`.
+If you have that version installed, it will not be automatically switched over to the new one (`rust-lang.rust-analyzer`).
+
+So if you are not running a Microsoft build of VS Code, our advice is to reinstall rust-analyzer from Code's extension page.
+This will ensure that you get updated versions in the future.
+If you've installed a VSIX from GitHub since March, it should get updated automatically, but it doesn't hurt to check.
+
+If you are using an official build of Code, or a different editor, you don't need to take any action.
+
+== New Features
+
+* pr:13525[] show signature help when calling generic types implementing `FnOnce`:
++
+image::https://user-images.githubusercontent.com/308347/200243832-b81303bd-b833-4d99-b96c-ecec6acdc2df.png["A screenshot showing signature help when calling a `FnOnce` parameter"]
+* pr:13516[] add "Convert `match` to `let`-``else``" assist:
++
+video::https://user-images.githubusercontent.com/308347/200244795-545f0465-ec0f-4d8c-8f70-5f08aea99bf0.mp4[options=loop]
+* pr:13527[] use `let`-`else` statements in "Convert to guarded return".
+* pr:13359[] add `rust-analyzer.assist.emitMustUse` config for inserting `#[must_use]` in `generate_enum_as_method`.
+
+== Fixes
+
+* pr:13454[] (first contribution) handle shadowing of locals in "Inline call".
+* pr:13508[] (first contribution) don't offer to remove unnecessary `async` in trait items.
+* pr:13523[] disregard type variable expectation for `if` expressions.
+* pr:13546[] lower unsafety of function pointer and item types.
+* pr:13517[] make custom expression prefix completions understand references.
+* pr:13549[] fix reference searching accounting for substrings instead of whole identifiers.
+* pr:13456[] generate SCIP symbols for local crates.
+
+== Internal Improvements
+
+* pr:13445[] (first contribution) fix some broken links in `guide.md`.
+* pr:13536[], pr:13556[] (first contribution) mention auto-published crates in the manual.
+* pr:13379[], pr:13435[] migrate assists to format args captures, parts 1 and 3.
+* pr:13544[] add rustbot features related to PR state labels.
+* pr:13541[] clarify which VS Code commands are meant for debugging.