Skip to content

PaymentInstructions::parse never returns if OM-based HRN lookup fails #11

@tnull

Description

@tnull

In

Ok(recv) => Box::pin(async move { Ok(recv.await) }),
we await receiving on the channel until the ChannelSend::complete is called, which however might never happen (e.g., if the onion messages get dropped, or, if the DNS resolver fails to validate the DNSSEC proof, in which case it simply doesn't reply).

We should probably find a way to complete the resolution future (with an error value) when cleaning up pending_resolutions.

(cc @TheBlueMatt)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions