Skip to content
This repository was archived by the owner on Nov 30, 2022. It is now read-only.

Commit 5dc3fd4

Browse files
committed
Add TODO about features to test once we bump MSRV
We get build errors when building with Rust 1.29 for `core2` and `schemars`. Add todos to remind us to test theses once we bump MSRV. Note the `schemars` cannot be added to the test matrix because it must be built with `std`, we must add a specific test for this combination. Example build error: ``` error: unable to get packages from source Caused by: failed to parse manifest at `/home/tobin/.cargo/registry/src/github.com-1ecc6299db9ec823/core2-0.3.3/Cargo.toml` Caused by: editions are unstable Caused by: feature `edition` is required ``` Add a TODO to `test.sh` to remind us to add `core2` to the features matrix once we bump MSRV. Add a commented out schemars/std test and a note to uncomment test once we bump MSRV past 1.29
1 parent 41807c0 commit 5dc3fd4

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

contrib/test.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
#!/bin/sh -ex
22

3+
# TODO: Add core2 here once we bump MSRV past 1.29
34
FEATURES="serde serde-std std"
45

56
if [ "$DO_ALLOC_TESTS" = true ]; then
@@ -41,6 +42,9 @@ if [ "$DO_FEATURE_MATRIX" = true ]; then
4142
done
4243
done
4344

45+
# Other combos
46+
# TODO: Add this test once we bump MSRV past 1.29
47+
# cargo test --all --no-default-features --features="std,schemars"
4448
fi
4549

4650
if [ "$DO_SCHEMARS_TESTS" = true ]; then

0 commit comments

Comments
 (0)