Merge #456: Add hidden RPCs syncwithvalidationinterfacequeue, mockscheduler and reconsiderblock

bab4647 fix(tests): move hidden RPC tests, fix modelled suffixes (RenatoBrittoAraujo)
7756c42 fix(mining): correct docs API version to v30 (RenatoBrittoAraujo)
3e14006 test(blockchain): test mockscheduler hidden RPC (RenatoBrittoAraujo)
e1bd874 feat(client): add mockscheduler hidden RPC (RenatoBrittoAraujo)
1846d7d test(blockchain): test reconsiderblock hidden RPC (RenatoBrittoAraujo)
af55bf2 feat(client): add reconsiderblock hidden RPC for all client versions (RenatoBrittoAraujo)
865d332 test(blockchain): test syncwithvalidationinterfacequeue RPC (RenatoBrittoAraujo)
0c0c0f3 feat(client): add syncwithvalidationinterfacequeue RPC (RenatoBrittoAraujo)

Pull request description:

  This PR:
  - Implements `syncwithvalidationinterfacequeue` and `reconsiderblock` in the v17 hidden module, add the client macro and test. Add the reexports for all later versions, as there are no changes in each up to v30.
  - Implements  `mockscheduler` RPC starting from v20 to v30.
  - Corrects a small error in v30 mining comment.

  Part of #333.

ACKs for top commit:
  tcharding:
    ACK bab4647

Tree-SHA512: 3a6a4fb17d931fbc1665024c7e4b5c3c2e9acceeb066ee58d4a54ca8001c0f722105f32b27932e4076796eded584c0fe3424222eecc3e0be0db17306e6cb89b7

Author: tcharding

client/src/client_sync/v17/hidden.rs

@@ -56,3 +56,27 @@ macro_rules! impl_client_v17__wait_for_new_block {
         }
     };
 }
+
+/// Implements Bitcoin Core JSON-RPC API method `syncwithvalidationinterfacequeue`.
+#[macro_export]
+macro_rules! impl_client_v17__sync_with_validation_interface_queue {
+    () => {
+        impl Client {
+            pub fn sync_with_validation_interface_queue(&self) -> Result<()> {
+                self.call("syncwithvalidationinterfacequeue", &[])
+            }
+        }
+    };
+}
+
+/// Implements Bitcoin Core JSON-RPC API method `reconsiderblock`.
+#[macro_export]
+macro_rules! impl_client_v17__reconsider_block {
+    () => {
+        impl Client {
+            pub fn reconsider_block(&self, blockhash: bitcoin::BlockHash) -> Result<()> {
+                self.call("reconsiderblock", &[into_json(blockhash)?])
+            }
+        }
+    };
+}

client/src/client_sync/v17/mod.rs

@@ -70,6 +70,8 @@ crate::impl_client_v17__estimate_raw_fee!();
 crate::impl_client_v17__wait_for_block!();
 crate::impl_client_v17__wait_for_block_height!();
 crate::impl_client_v17__wait_for_new_block!();
+crate::impl_client_v17__sync_with_validation_interface_queue!();
+crate::impl_client_v17__reconsider_block!();
 
 // == Mining ==
 crate::impl_client_v17__get_block_template!();

client/src/client_sync/v18/mod.rs

@@ -75,6 +75,8 @@ crate::impl_client_v17__estimate_raw_fee!();
 crate::impl_client_v17__wait_for_block!();
 crate::impl_client_v17__wait_for_block_height!();
 crate::impl_client_v17__wait_for_new_block!();
+crate::impl_client_v17__sync_with_validation_interface_queue!();
+crate::impl_client_v17__reconsider_block!();
 
 // == Mining ==
 crate::impl_client_v17__get_block_template!();

client/src/client_sync/v19/mod.rs

@@ -70,6 +70,8 @@ crate::impl_client_v17__estimate_raw_fee!();
 crate::impl_client_v17__wait_for_block!();
 crate::impl_client_v17__wait_for_block_height!();
 crate::impl_client_v17__wait_for_new_block!();
+crate::impl_client_v17__sync_with_validation_interface_queue!();
+crate::impl_client_v17__reconsider_block!();
 
 // == Mining ==
 crate::impl_client_v17__get_block_template!();

client/src/client_sync/v20/hidden.rs

@@ -0,0 +1,22 @@
+// SPDX-License-Identifier: CC0-1.0
+
+//! Macros for implementing JSON-RPC methods on a client.
+//!
+//! Specifically this is `== Hidden ==` methods that are not listed in the
+//! API docs of Bitcoin Core `v0.20`.
+//!
+//! All macros require `Client` to be in scope.
+//!
+//! See or use the `define_jsonrpc_bitreq_client!` macro to define a `Client`.
+
+/// Implements Bitcoin Core JSON-RPC API method `mockscheduler`.
+#[macro_export]
+macro_rules! impl_client_v20__mock_scheduler {
+    () => {
+        impl Client {
+            pub fn mock_scheduler(&self, delta_time: u64) -> Result<()> {
+                self.call("mockscheduler", &[into_json(delta_time)?])
+            }
+        }
+    };
+}

client/src/client_sync/v20/mod.rs

@@ -5,6 +5,7 @@
 //! We ignore option arguments unless they effect the shape of the returned JSON data.
 
 pub mod generating;
+pub mod hidden;
 
 use std::collections::BTreeMap;
 use std::path::Path;
@@ -70,6 +71,9 @@ crate::impl_client_v17__estimate_raw_fee!();
 crate::impl_client_v17__wait_for_block!();
 crate::impl_client_v17__wait_for_block_height!();
 crate::impl_client_v17__wait_for_new_block!();
+crate::impl_client_v17__sync_with_validation_interface_queue!();
+crate::impl_client_v17__reconsider_block!();
+crate::impl_client_v20__mock_scheduler!();
 
 // == Mining ==
 crate::impl_client_v17__get_block_template!();

client/src/client_sync/v21/mod.rs

@@ -76,6 +76,9 @@ crate::impl_client_v17__estimate_raw_fee!();
 crate::impl_client_v17__wait_for_block!();
 crate::impl_client_v17__wait_for_block_height!();
 crate::impl_client_v17__wait_for_new_block!();
+crate::impl_client_v17__sync_with_validation_interface_queue!();
+crate::impl_client_v17__reconsider_block!();
+crate::impl_client_v20__mock_scheduler!();
 
 // == Mining ==
 crate::impl_client_v17__get_block_template!();

client/src/client_sync/v22/mod.rs

@@ -76,6 +76,9 @@ crate::impl_client_v17__estimate_raw_fee!();
 crate::impl_client_v17__wait_for_block!();
 crate::impl_client_v17__wait_for_block_height!();
 crate::impl_client_v17__wait_for_new_block!();
+crate::impl_client_v17__sync_with_validation_interface_queue!();
+crate::impl_client_v17__reconsider_block!();
+crate::impl_client_v20__mock_scheduler!();
 
 // == Mining ==
 crate::impl_client_v17__get_block_template!();

client/src/client_sync/v23/mod.rs

@@ -78,6 +78,9 @@ crate::impl_client_v17__estimate_raw_fee!();
 crate::impl_client_v17__wait_for_block!();
 crate::impl_client_v17__wait_for_block_height!();
 crate::impl_client_v17__wait_for_new_block!();
+crate::impl_client_v17__sync_with_validation_interface_queue!();
+crate::impl_client_v17__reconsider_block!();
+crate::impl_client_v20__mock_scheduler!();
 
 // == Mining ==
 crate::impl_client_v17__get_block_template!();

client/src/client_sync/v24/mod.rs

@@ -79,6 +79,9 @@ crate::impl_client_v17__estimate_raw_fee!();
 crate::impl_client_v17__wait_for_block!();
 crate::impl_client_v17__wait_for_block_height!();
 crate::impl_client_v17__wait_for_new_block!();
+crate::impl_client_v17__sync_with_validation_interface_queue!();
+crate::impl_client_v17__reconsider_block!();
+crate::impl_client_v20__mock_scheduler!();
 
 // == Mining ==
 crate::impl_client_v17__get_block_template!();