Merge #231: Implement abandontransaction and test

5d6b977 Implement abandontransaction and test (GideonBature)

Pull request description:

  The JSON-RPC method `abandontransaction` does return null. We want to test this to catch any changes in behavior in future Core versions.

  This PR adds a client function that errors if the return value is anything other than `null`, along with an integration test that calls this function.

  Ref: [#116](#116)

ACKs for top commit:
  jamillambert:
    ACK 5d6b977
  tcharding:
    ACK 5d6b977

Tree-SHA512: 4801603b099f0fd04fd234dced71318e619cb201a22cb801140010cc88ce4ed316e372718c8c475b52e4caed8ce7cf8676b5197838953ee35e6c5482920b49ca

Author: tcharding

client/src/client_sync/v17/mod.rs

@@ -108,6 +108,7 @@ crate::impl_client_v17__validate_address!();
 crate::impl_client_v17__verify_message!();
 
 // == Wallet ==
+crate::impl_client_v17__abandon_transaction!();
 crate::impl_client_v17__add_multisig_address!();
 crate::impl_client_v17__bump_fee!();
 crate::impl_client_v17__create_wallet!();

client/src/client_sync/v17/wallet.rs

@@ -9,6 +9,22 @@
 //!
 //! See or use the `define_jsonrpc_minreq_client!` macro to define a `Client`.
 
+/// Implements Bitcoin Core JSON-RPC API method `abandontransaction`.
+#[macro_export]
+macro_rules! impl_client_v17__abandon_transaction {
+    () => {
+        impl Client {
+            pub fn abandon_transaction(&self, txid: Txid) -> Result<()> {
+                match self.call("abandontransaction", &[into_json(txid)?]) {
+                    Ok(serde_json::Value::Null) => Ok(()),
+                    Ok(res) => Err(Error::Returned(res.to_string())),
+                    Err(err) => Err(err.into()),
+                }
+            }
+        }
+    };
+}
+
 /// Implements Bitcoin Core JSON-RPC API method `addmultisigaddress`.
 #[macro_export]
 macro_rules! impl_client_v17__add_multisig_address {

client/src/client_sync/v18/mod.rs

@@ -116,6 +116,7 @@ crate::impl_client_v17__validate_address!();
 crate::impl_client_v17__verify_message!();
 
 // == Wallet ==
+crate::impl_client_v17__abandon_transaction!();
 crate::impl_client_v17__add_multisig_address!();
 crate::impl_client_v17__bump_fee!();
 crate::impl_client_v17__create_wallet!();

client/src/client_sync/v19/mod.rs

@@ -114,6 +114,7 @@ crate::impl_client_v17__validate_address!();
 crate::impl_client_v17__verify_message!();
 
 // == Wallet ==
+crate::impl_client_v17__abandon_transaction!();
 crate::impl_client_v17__add_multisig_address!();
 crate::impl_client_v17__bump_fee!();
 crate::impl_client_v17__create_wallet!();

client/src/client_sync/v20/mod.rs

@@ -111,6 +111,7 @@ crate::impl_client_v17__validate_address!();
 crate::impl_client_v17__verify_message!();
 
 // == Wallet ==
+crate::impl_client_v17__abandon_transaction!();
 crate::impl_client_v17__add_multisig_address!();
 crate::impl_client_v17__bump_fee!();
 crate::impl_client_v17__create_wallet!();

client/src/client_sync/v21/mod.rs

@@ -113,6 +113,7 @@ crate::impl_client_v17__validate_address!();
 crate::impl_client_v17__verify_message!();
 
 // == Wallet ==
+crate::impl_client_v17__abandon_transaction!();
 crate::impl_client_v17__add_multisig_address!();
 crate::impl_client_v17__bump_fee!();
 crate::impl_client_v17__create_wallet!();

client/src/client_sync/v22/mod.rs

@@ -113,6 +113,7 @@ crate::impl_client_v17__validate_address!();
 crate::impl_client_v17__verify_message!();
 
 // == Wallet ==
+crate::impl_client_v17__abandon_transaction!();
 crate::impl_client_v17__add_multisig_address!();
 crate::impl_client_v17__bump_fee!();
 crate::impl_client_v17__create_wallet!();

client/src/client_sync/v23/mod.rs

@@ -115,6 +115,7 @@ crate::impl_client_v17__validate_address!();
 crate::impl_client_v17__verify_message!();
 
 // == Wallet ==
+crate::impl_client_v17__abandon_transaction!();
 crate::impl_client_v17__add_multisig_address!();
 crate::impl_client_v17__bump_fee!();
 crate::impl_client_v23__create_wallet!();

client/src/client_sync/v24/mod.rs

@@ -112,6 +112,7 @@ crate::impl_client_v17__validate_address!();
 crate::impl_client_v17__verify_message!();
 
 // == Wallet ==
+crate::impl_client_v17__abandon_transaction!();
 crate::impl_client_v17__add_multisig_address!();
 crate::impl_client_v17__bump_fee!();
 crate::impl_client_v23__create_wallet!();

client/src/client_sync/v25/mod.rs

@@ -112,6 +112,7 @@ crate::impl_client_v17__validate_address!();
 crate::impl_client_v17__verify_message!();
 
 // == Wallet ==
+crate::impl_client_v17__abandon_transaction!();
 crate::impl_client_v17__add_multisig_address!();
 crate::impl_client_v17__bump_fee!();
 crate::impl_client_v23__create_wallet!();