Merge #247: Implement backupwallet method and test

8c14cd0 Implement backupwallet method and test (GideonBature)

Pull request description:

  The JSON-RPC method `backupwallet` does return null. We want to test this to catch any changes in behavior in future Core versions.

  This PR adds a client function that errors if the return value is anything other than `null`, along with an integration test that calls this function.

  Ref: [#116](#116)

ACKs for top commit:
  tcharding:
    ACK 8c14cd0

Tree-SHA512: ee68c57b2e8be5c10408b7e21f05d477429d20bcd6a6e4758a933f6607f277f6d4cca825885cca1780524761ffe89c2ad64866bee76d5b934f27807efc0f2626

Author: tcharding

client/src/client_sync/v17/mod.rs

@@ -112,6 +112,7 @@ crate::impl_client_v17__verify_message!();
 crate::impl_client_v17__abandon_transaction!();
 crate::impl_client_v17__abort_rescan!();
 crate::impl_client_v17__add_multisig_address!();
+crate::impl_client_v17__backup_wallet!();
 crate::impl_client_v17__bump_fee!();
 crate::impl_client_v17__create_wallet!();
 crate::impl_client_v17__dump_priv_key!();

client/src/client_sync/v17/wallet.rs

@@ -59,6 +59,22 @@ macro_rules! impl_client_v17__add_multisig_address {
     };
 }
 
+/// Implements Bitcoin Core JSON-RPC API method `bumpfee`.
+#[macro_export]
+macro_rules! impl_client_v17__backup_wallet {
+    () => {
+        impl Client {
+            pub fn backup_wallet(&self, destination: &Path) -> Result<()> {
+                match self.call("backupwallet", &[into_json(destination)?]) {
+                    Ok(serde_json::Value::Null) => Ok(()),
+                    Ok(res) => Err(Error::Returned(res.to_string())),
+                    Err(err) => Err(err.into()),
+                }
+            }
+        }
+    };
+}
+
 /// Implements Bitcoin Core JSON-RPC API method `bumpfee`.
 #[macro_export]
 macro_rules! impl_client_v17__bump_fee {

client/src/client_sync/v18/mod.rs

@@ -126,6 +126,7 @@ crate::impl_client_v17__verify_message!();
 crate::impl_client_v17__abandon_transaction!();
 crate::impl_client_v17__abort_rescan!();
 crate::impl_client_v17__add_multisig_address!();
+crate::impl_client_v17__backup_wallet!();
 crate::impl_client_v17__bump_fee!();
 crate::impl_client_v17__create_wallet!();
 crate::impl_client_v17__dump_priv_key!();

client/src/client_sync/v19/mod.rs

@@ -121,6 +121,7 @@ crate::impl_client_v17__verify_message!();
 crate::impl_client_v17__abandon_transaction!();
 crate::impl_client_v17__abort_rescan!();
 crate::impl_client_v17__add_multisig_address!();
+crate::impl_client_v17__backup_wallet!();
 crate::impl_client_v17__bump_fee!();
 crate::impl_client_v17__create_wallet!();
 crate::impl_client_v17__dump_priv_key!();

client/src/client_sync/v20/mod.rs

@@ -118,6 +118,7 @@ crate::impl_client_v17__verify_message!();
 crate::impl_client_v17__abandon_transaction!();
 crate::impl_client_v17__abort_rescan!();
 crate::impl_client_v17__add_multisig_address!();
+crate::impl_client_v17__backup_wallet!();
 crate::impl_client_v17__bump_fee!();
 crate::impl_client_v17__create_wallet!();
 crate::impl_client_v17__dump_priv_key!();

client/src/client_sync/v21/mod.rs

@@ -120,6 +120,7 @@ crate::impl_client_v17__verify_message!();
 crate::impl_client_v17__abandon_transaction!();
 crate::impl_client_v17__abort_rescan!();
 crate::impl_client_v17__add_multisig_address!();
+crate::impl_client_v17__backup_wallet!();
 crate::impl_client_v17__bump_fee!();
 crate::impl_client_v17__create_wallet!();
 crate::impl_client_v17__dump_priv_key!();

client/src/client_sync/v22/mod.rs

@@ -120,6 +120,7 @@ crate::impl_client_v17__verify_message!();
 crate::impl_client_v17__abandon_transaction!();
 crate::impl_client_v17__abort_rescan!();
 crate::impl_client_v17__add_multisig_address!();
+crate::impl_client_v17__backup_wallet!();
 crate::impl_client_v17__bump_fee!();
 crate::impl_client_v17__create_wallet!();
 crate::impl_client_v17__dump_priv_key!();

client/src/client_sync/v23/mod.rs

@@ -122,6 +122,7 @@ crate::impl_client_v17__verify_message!();
 crate::impl_client_v17__abandon_transaction!();
 crate::impl_client_v17__abort_rescan!();
 crate::impl_client_v17__add_multisig_address!();
+crate::impl_client_v17__backup_wallet!();
 crate::impl_client_v17__bump_fee!();
 crate::impl_client_v23__create_wallet!();
 crate::impl_client_v17__dump_priv_key!();

client/src/client_sync/v24/mod.rs

@@ -119,6 +119,7 @@ crate::impl_client_v17__verify_message!();
 crate::impl_client_v17__abandon_transaction!();
 crate::impl_client_v17__abort_rescan!();
 crate::impl_client_v17__add_multisig_address!();
+crate::impl_client_v17__backup_wallet!();
 crate::impl_client_v17__bump_fee!();
 crate::impl_client_v23__create_wallet!();
 crate::impl_client_v17__dump_priv_key!();

client/src/client_sync/v25/mod.rs

@@ -119,6 +119,7 @@ crate::impl_client_v17__verify_message!();
 crate::impl_client_v17__abandon_transaction!();
 crate::impl_client_v17__abort_rescan!();
 crate::impl_client_v17__add_multisig_address!();
+crate::impl_client_v17__backup_wallet!();
 crate::impl_client_v17__bump_fee!();
 crate::impl_client_v23__create_wallet!();
 crate::impl_client_v17__dump_priv_key!();