Test and update getwalletinfo
#345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamillambert
force-pushed
the
0827-getwalletinfo
branch
from
1824ca3 to
453fc48
Compare
|
NB. the force push from today was from |
|
453fc48 LGTM |
`getwalletinfo` was implemented for v17 only and untested. There are return changes in v18, v19, v21, v23 and v26. Add the updated structs in all versions, update the model and add new `into_model()`. Add a test with version specific sections to test the new sub-structs. Update the types tables and reexports.
jamillambert
force-pushed
the
0827-getwalletinfo
branch
from
453fc48 to
e15aee7
Compare
|
Rebased on master, no changes. |
tcharding
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getwalletinfowas implemented for v17 only and untested. There are return changes in v18, v19, v21, v23 and v26.into_model().