Merge #11: Fix the fuzz bug

6646692 Stop treating fuzz as a special case (Tobin C. Harding)
97fba0c Use say_err (Tobin C. Harding)
274bdbb Ignore dynamic paths with shellcheck (Tobin C. Harding)

Pull request description:

  This PR dose a few things:

  - Clear shellhcheck warnings due to dynamic file paths (not sure why this passed CI before)
  - Use `say_err` to clear another `shellcheck` warning (that I was unable to repro locally)
  - Runs `cargo build` and `cargo test` for all crates instead of treating `fuzz` as a special case

  Resolve: #10

ACKs for top commit:
  apoelstra:
    ACK 6646692

Tree-SHA512: 9ad333cc0c30f5d08bd6a04c7e59fce9c4a0781e088dd93f2a2ea5b782a25b48b5529fb0f7d44561df9500590190ec5a5c93c984b337eb4118c97f9760d8cb2a

Author: apoelstra

ci/run_task.sh

@@ -1,6 +1,9 @@
 #!/usr/bin/env bash
 #
 # Script used to run CI jobs, can also be used from the command line.
+#
+# Shellcheck can't search dynamic paths
+# shellcheck source=/dev/null
 
 set -euox pipefail
 
@@ -111,28 +114,25 @@ build_and_test() {
     for crate in "${CRATES[@]}"; do
         local test_vars_script="$REPO_DIR/$crate/contrib/test_vars.sh"
 
-        # Building the fuzz crate is more-or-less just a sanity check.
-        if [ "$crate" = "fuzz" ]; then
-            pushd "$REPO_DIR/$crate" > /dev/null
-            cargo --locked build
-            popd > /dev/null
-            break
-        fi
+        # Clean variables and also make sure they are defined.
+        FEATURES_WITH_STD=""
+        FEATURES_WITH_NO_STD=""
+        FEATURES_WITHOUT_STD=""
+        EXAMPLES=""
 
         verbose_say "Sourcing $test_vars_script"
         if [ -e "$test_vars_script" ]; then
             # Set crate specific variables.
             # can't find the file because of the ENV var
             # shellcheck source=/dev/null
             . "$test_vars_script"
-        else
-            err "Missing $test_vars_script"
-        fi
-        verbose_say "Got vars"
-        verbose_say "FEATURES_WITH_STD: ${FEATURES_WITH_STD:-}"
-        verbose_say "FEATURES_WITHOUT_STD: ${FEATURES_WITHOUT_STD:-}"
-        verbose_say "EXAMPLES: ${EXAMPLES:-}"
 
+            verbose_say "Got test vars:"
+            verbose_say "FEATURES_WITH_STD: ${FEATURES_WITH_STD}"
+            verbose_say "FEATURES_WITH_NO_STD: ${FEATURES_WITH_NO_STD}"
+            verbose_say "FEATURES_WITHOUT_STD: ${FEATURES_WITHOUT_STD}"
+            verbose_say "EXAMPLES: ${EXAMPLES:-}"
+        fi
         pushd "$REPO_DIR/$crate" > /dev/null
 
         do_test
@@ -147,7 +147,7 @@ do_test() {
     $cargo build
     $cargo test
 
-    if [ -n "${EXAMPLES+x}" ]; then
+    if [ -n "${EXAMPLES}" ]; then
         for example in $EXAMPLES; do # EXAMPLES is set in contrib/test_vars.sh
             name="$(echo "$example" | cut -d ':' -f 1)"
             features="$(echo "$example" | cut -d ':' -f 2)"
@@ -165,21 +165,21 @@ do_test() {
 # can be better controlled.
 do_feature_matrix() {
     # rust-miniscript only: https://github.com/rust-bitcoin/rust-miniscript/issues/681
-    if [ -n "${FEATURES_WITH_NO_STD+x}" ]; then
+    if [ -n "${FEATURES_WITH_NO_STD}" ]; then
         $cargo build --no-default-features --features="no-std"
         $cargo test --no-default-features --features="no-std"
 
-        loop_features "no-std" "${FEATURES_WITH_NO_STD:-}"
+        loop_features "no-std" "${FEATURES_WITH_NO_STD}"
     else
         $cargo build --no-default-features
         $cargo test --no-default-features
     fi
 
-    if [ -z "${FEATURES_WITH_STD+x}" ]; then
-        loop_features "std" "${FEATURES_WITH_STD:-}"
+    if [ -n "${FEATURES_WITH_STD}" ]; then
+        loop_features "std" "${FEATURES_WITH_STD}"
     fi
 
-    if [ -z "${FEATURES_WITHOUT_STD+x}" ]; then
+    if [ -n "${FEATURES_WITHOUT_STD}" ]; then
         loop_features "" "$FEATURES_WITHOUT_STD"
     fi
 }
@@ -262,9 +262,8 @@ do_dup_deps() {
     duplicate_dependencies=$(eval "$tree_cmd")
 
     if [ "$duplicate_dependencies" -ne 0 ]; then
-        echo "Dependency tree is broken, contains duplicates"
         cargo tree  --target=all --all-features --duplicates
-        exit 1
+        say_err "Dependency tree is broken, contains duplicates"
     fi
 
     set -o pipefail