Merge branch 'master' into 202008-getnettotals

Author: stevenroose

client/src/client.rs

@@ -285,8 +285,10 @@ pub trait RpcApi: Sized {
             opt_into_json(passphrase)?,
             opt_into_json(avoid_reuse)?,
         ];
-        self.call("createwallet", handle_defaults(
-            &mut args, &[false.into(), false.into(), into_json("")?, false.into()]))
+        self.call(
+            "createwallet",
+            handle_defaults(&mut args, &[false.into(), false.into(), into_json("")?, false.into()]),
+        )
     }
 
     fn list_wallets(&self) -> Result<Vec<String>> {
@@ -994,6 +996,17 @@ pub trait RpcApi: Sized {
     fn get_net_totals(&self) -> Result<json::GetNetTotalsResult> {
         self.call("getnettotals", &[])
     }
+
+    /// Returns the estimated network hashes per second based on the last n blocks.
+    fn get_network_hash_ps(&self, nblocks: Option<u64>, height: Option<u64>) -> Result<f64> {
+        let mut args = [opt_into_json(nblocks)?, opt_into_json(height)?];
+        self.call("getnetworkhashps", handle_defaults(&mut args, &[null(), null()]))
+    }
+
+    /// Returns the total uptime of the server in seconds
+    fn uptime(&self) -> Result<u64> {
+        self.call("uptime", &[])
+    }
 }
 
 /// Client implements a JSON-RPC client for the Bitcoin Core daemon or compatible APIs.

integration_test/src/main.rs

@@ -148,6 +148,8 @@ fn main() {
     test_rescan_blockchain(&cl);
     test_create_wallet(&cl);
     test_get_net_totals(&cl);
+    test_get_network_hash_ps(&cl);
+    test_uptime(&cl);
     //TODO import_multi(
     //TODO verify_message(
     //TODO wait_for_new_block(&self, timeout: u64) -> Result<json::BlockRef> {
@@ -215,11 +217,13 @@ fn test_get_balance_generate_to_address(cl: &Client) {
 }
 
 fn test_get_balances_generate_to_address(cl: &Client) {
-    let initial = cl.get_balances().unwrap();
+    if version() >= 190000 {
+        let initial = cl.get_balances().unwrap();
 
-    let blocks = cl.generate_to_address(500, &cl.get_new_address(None, None).unwrap()).unwrap();
-    assert_eq!(blocks.len(), 500);
-    assert_ne!(cl.get_balances().unwrap(), initial);
+        let blocks = cl.generate_to_address(500, &cl.get_new_address(None, None).unwrap()).unwrap();
+        assert_eq!(blocks.len(), 500);
+        assert_ne!(cl.get_balances().unwrap(), initial);
+    }
 }
 
 fn test_get_best_block_hash(cl: &Client) {
@@ -827,44 +831,42 @@ fn test_create_wallet(cl: &Client) {
             blank: Some(true),
             passphrase: None,
             avoid_reuse: None,
-        }
+        },
     ];
 
     if version() >= 190000 {
-        wallet_params.push(
-            WalletParams {
-                name: wallet_names[3],
-                disable_private_keys: None,
-                blank: None,
-                passphrase: Some("pass"),
-                avoid_reuse: None,
-            }
-        );
-        wallet_params.push(
-            WalletParams {
-                name: wallet_names[4],
-                disable_private_keys: None,
-                blank: None,
-                passphrase: None,
-                avoid_reuse: Some(true),
-            }
-        );
+        wallet_params.push(WalletParams {
+            name: wallet_names[3],
+            disable_private_keys: None,
+            blank: None,
+            passphrase: Some("pass"),
+            avoid_reuse: None,
+        });
+        wallet_params.push(WalletParams {
+            name: wallet_names[4],
+            disable_private_keys: None,
+            blank: None,
+            passphrase: None,
+            avoid_reuse: Some(true),
+        });
     }
 
     for wallet_param in wallet_params {
         let result = cl
-        .create_wallet(
-            wallet_param.name,
-            wallet_param.disable_private_keys,
-            wallet_param.blank,
-            wallet_param.passphrase,
-            wallet_param.avoid_reuse,
-        )
-        .unwrap();
+            .create_wallet(
+                wallet_param.name,
+                wallet_param.disable_private_keys,
+                wallet_param.blank,
+                wallet_param.passphrase,
+                wallet_param.avoid_reuse,
+            )
+            .unwrap();
 
         assert_eq!(result.name, wallet_param.name);
         let expected_warning = match (wallet_param.passphrase, wallet_param.avoid_reuse) {
-            (None, Some(true)) => Some("Empty string given as passphrase, wallet will not be encrypted.".to_string()),
+            (None, Some(true)) => {
+                Some("Empty string given as passphrase, wallet will not be encrypted.".to_string())
+            }
             _ => Some("".to_string()),
         };
         assert_eq!(result.warning, expected_warning);
@@ -883,7 +885,8 @@ fn test_create_wallet(cl: &Client) {
         assert_eq!(wallet_info.avoid_reuse.unwrap_or(false), has_avoid_reuse);
         assert_eq!(
             wallet_info.scanning.unwrap_or(json::ScanningDetails::NotScanning(false)),
-            json::ScanningDetails::NotScanning(false));
+            json::ScanningDetails::NotScanning(false)
+        );
     }
 
     let mut wallet_list = cl.list_wallets().unwrap();
@@ -901,6 +904,14 @@ fn test_get_net_totals(cl: &Client) {
     cl.get_net_totals().unwrap();
 }
 
+fn test_get_network_hash_ps(cl: &Client) {
+    cl.get_network_hash_ps(None, None).unwrap();
+}
+
+fn test_uptime(cl: &Client) {
+    cl.uptime().unwrap();
+}
+
 fn test_stop(cl: Client) {
     println!("Stopping: '{}'", cl.stop().unwrap());
 }

json/src/lib.rs

@@ -156,7 +156,10 @@ pub struct GetWalletInfoResult {
 #[derive(Clone, PartialEq, Debug, Deserialize, Serialize)]
 #[serde(untagged)]
 pub enum ScanningDetails {
-    Scanning { duration: usize, progress: f32 },
+    Scanning {
+        duration: usize,
+        progress: f32,
+    },
     NotScanning(bool),
 }
 
@@ -393,6 +396,7 @@ pub struct WalletTxInfo {
     pub blockhash: Option<bitcoin::BlockHash>,
     pub blockindex: Option<usize>,
     pub blocktime: Option<u64>,
+    pub blockheight: Option<u32>,
     pub txid: bitcoin::Txid,
     pub time: u64,
     pub timereceived: u64,