Merge #524: hexify for better error message

a0b001b hexify for better error message (Harshil Jani)

Pull request description:

  This PR hexifies the Error implementation as requested in TODO. Let me know if this works and then I can remove the "TODO : Hexify this " Comment from there.

  Signed-off-by: Harshil Jani <[email protected]>

ACKs for top commit:
  apoelstra:
    ACK a0b001b

Tree-SHA512: 9ee5020104af93a8d06960c7627e7bf344d18f2f5570b6333935522c95d13499b4a67abb0153f85c06d376d79be189a3bc61f45254aa871fb74a7716b848ee77

Author: apoelstra

src/lib.rs

@@ -512,7 +512,10 @@ impl fmt::Display for Error {
         match *self {
             Error::InvalidOpcode(op) => write!(f, "invalid opcode {}", op),
             Error::NonMinimalVerify(ref tok) => write!(f, "{} VERIFY", tok),
-            Error::InvalidPush(ref push) => write!(f, "invalid push {:?}", push), // TODO hexify this
+            Error::InvalidPush(ref push) => {
+                write!(f, "invalid push ")?;
+                bitcoin::hashes::hex::format_hex(push, f)
+            },
             Error::Script(ref e) => fmt::Display::fmt(e, f),
             Error::AddrError(ref e) => fmt::Display::fmt(e, f),
             Error::CmsTooManyKeys(n) => write!(f, "checkmultisig with {} keys", n),