Commit 2113e8d
committed
Merge #63: Use repository secret instead of default token
502461d Use repository secret instead of default token (Nick Johnson)
Pull request description:
Without setting a `token` the job uses the default `GITHUB_TOKEN` of the repository. But this only works if the "Allow GitHub Actions to create and approve pull requests" is enabled on the repository. I don't have perms to see if it is here on `rust-psbt`, but I bet it isn't. And I bet it *is* enabled over on `rust-bitcoin-maintainer-tools` which is why it worked over there.
In any case, it is probably better to keep that setting disabled and use a user account PAT with just repo permission. I added mine to the `RBMT_PRS` secret in this repository (which I had permissions to do). Updating the job to use it.
I have a PR open on the rbmt side to document these fun little github quirks: rust-bitcoin/rust-bitcoin-maintainer-tools#79
ACKs for top commit:
nymius:
ACK 502461d
tcharding:
ACK 502461d
Tree-SHA512: 7b481a4cc1148202c8f213a4b723c58db65a8b5ddd4c572a525c485b130a06e5feeb77ae6279665faabc5f79dbb2344bfd84ac0834aa2e13b1ebcf18a89b3cc41 file changed
+4
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
| 19 | + | |
18 | 20 | | |
| 21 | + | |
| 22 | + | |
0 commit comments