Skip to content

Commit 2113e8d

Browse files
committed
Merge #63: Use repository secret instead of default token
502461d Use repository secret instead of default token (Nick Johnson) Pull request description: Without setting a `token` the job uses the default `GITHUB_TOKEN` of the repository. But this only works if the "Allow GitHub Actions to create and approve pull requests" is enabled on the repository. I don't have perms to see if it is here on `rust-psbt`, but I bet it isn't. And I bet it *is* enabled over on `rust-bitcoin-maintainer-tools` which is why it worked over there. In any case, it is probably better to keep that setting disabled and use a user account PAT with just repo permission. I added mine to the `RBMT_PRS` secret in this repository (which I had permissions to do). Updating the job to use it. I have a PR open on the rbmt side to document these fun little github quirks: rust-bitcoin/rust-bitcoin-maintainer-tools#79 ACKs for top commit: nymius: ACK 502461d tcharding: ACK 502461d Tree-SHA512: 7b481a4cc1148202c8f213a4b723c58db65a8b5ddd4c572a525c485b130a06e5feeb77ae6279665faabc5f79dbb2344bfd84ac0834aa2e13b1ebcf18a89b3cc4
2 parents 51a519b + 502461d commit 2113e8d

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

.github/workflows/update-toolchains.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,8 @@ jobs:
1515
steps:
1616
- uses: actions/checkout@v6
1717
- uses: rust-bitcoin/rust-bitcoin-maintainer-tools/.github/actions/update-nightly@320a06a6647c90ac97452b20fad5b689905a9791
18+
with:
19+
token: ${{ secrets.RBMT_PRS }}
1820
- uses: rust-bitcoin/rust-bitcoin-maintainer-tools/.github/actions/update-stable@320a06a6647c90ac97452b20fad5b689905a9791
21+
with:
22+
token: ${{ secrets.RBMT_PRS }}

0 commit comments

Comments
 (0)