Skip to content

Commit 8d84857

Browse files
committed
Merge #460: HOT FIX: Enable "rand/std_rng" feature
4e44abc Bump version to v0.23.1 (Tobin C. Harding) c36b437 Enable rand/std_rng feature (Tobin C. Harding) Pull request description: Hot fix because currently attempting to use secp256 v0.23.0 as a dependency throws a secp build error. We recently upgraded the rand dependency and we use it behind code feature gated on "rand-std". In that code we use `thread_rng` but this is only available if the "std_rng" feature is turned on, however in non-dev builds we do not enable this feature, we have a "rand-std" feature that enables "rand/std", it should also enable "std_rng". Enable "rand/std_rng" in the "rand-std" feature. I threw a version bump patch on this too in case we want to merge and release this fix (assuming I'm not mistaken about the 0.23.0 release), its Friday afternoon right now for me so if you want to forge ahead feel free to do what ever needs doing, don't wait for me and this PR :) ACKs for top commit: apoelstra: ACK 4e44abc Tree-SHA512: a76b4a94cea219f6cac3fe33efd6913b713f781917c9cdf6c5265e4021d57a91cae53ca4bb396deea654b976495843fdbad660959356669299b1c7c0b2371f80
2 parents ff7c347 + 4e44abc commit 8d84857

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# 0.23.1 - 2022-06-24
2+
3+
[Enable "rand/std_rng" feature](https://github.com/rust-bitcoin/rust-secp256k1/pull/460) when the crate's "rnd-std" feature is enabled.
4+
15
# 0.23.0 - 2022-06-21
26

37
The major change in this version is the increase of the Minimum Supported Rust Version (MSRV) from 1.29 to 1.41.1, this is a big change because it introduces Rust Edition 2018 to the codebase along with all the benefits that brings.

Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "secp256k1"
3-
version = "0.23.0"
3+
version = "0.23.1"
44
authors = [ "Dawid Ciężarkiewicz <[email protected]>",
55
"Andrew Poelstra <[email protected]>" ]
66
license = "CC0-1.0"
@@ -24,7 +24,7 @@ std = ["alloc", "secp256k1-sys/std"]
2424
# allow use of Secp256k1::new and related API that requires an allocator
2525
alloc = ["secp256k1-sys/alloc"]
2626
bitcoin-hashes-std = ["bitcoin_hashes/std"]
27-
rand-std = ["rand/std"]
27+
rand-std = ["rand/std", "rand/std_rng"]
2828
recovery = ["secp256k1-sys/recovery"]
2929
lowmemory = ["secp256k1-sys/lowmemory"]
3030
global-context = ["std"]

0 commit comments

Comments
 (0)