Make RecoveryId an enum
#743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamaharon
force-pushed
the
recoveryid-enum
branch
from
b3a9908 to
f6a76af
Compare
|
In f6a76af: There is an |
liamaharon
force-pushed
the
recoveryid-enum
branch
from
f6a76af to
d3e5ceb
Compare
|
Good catch @apoelstra, fixed it |
liamaharon
force-pushed
the
recoveryid-enum
branch
from
d3e5ceb to
fa0c086
Compare
|
Force pushed a lint fix |
tcharding
approved these changes
Sep 16, 2024
tcharding
added a commit
to tcharding/rust-secp256k1
that referenced
this pull request
Jun 12, 2025
The `RecoveryId` is an enum but is typically serialized as an integer. We used to provide a `to_i32` function before rust-bitcoin#743. Add a `to_u8` getter to the `RecoveryId`
tcharding
added a commit
to tcharding/rust-secp256k1
that referenced
this pull request
Jun 12, 2025
The `i32` is a hangover from before rust-bitcoin#743, now we have a nice enum and a `from_u8_masked` constructor (along with a `to_u8` getter) lets make the `From<RecoveryId>` impl be on `u8` instead of on `i32`.
tcharding
added a commit
to tcharding/rust-secp256k1
that referenced
this pull request
Jun 12, 2025
The `i32` is a hangover from before rust-bitcoin#743, now we have a nice enum and a `from_u8_masked` constructor (along with a `to_u8` getter) lets make the `From<RecoveryId>` impl be on `u8` instead of on `i32`.
tcharding
added a commit
to tcharding/rust-secp256k1
that referenced
this pull request
Jun 12, 2025
The `i32` is a hangover from before rust-bitcoin#743, now we have a nice enum and a `from_u8_masked` constructor (along with a `to_u8` getter) lets make the `From<RecoveryId>` impl be on `u8` instead of on `i32`.
chain-forgexcr45
added a commit
to chain-forgexcr45/rust-secp256k1
that referenced
this pull request
Sep 28, 2025
fa0c086431c9fc6ee872d6a14feccee6eb73dfb5 refactor: recoveryid into enum (Liam Aharon)
Pull request description:
Closes #727
- Refactors `RecoveryId` into an enum.
- Replaces custom type methods `from_i32` and `to_i32` with `TryFrom<i32>` and `Into<i32>` (via `From<RecoveryId> for i32`) implementations.
- Removes derive `Ord` `PartialOrd` and `Hash`, they don't appear to be used. I can implement on the enum if we want to keep them.
ACKs for top commit:
apoelstra:
ACK fa0c086431c9fc6ee872d6a14feccee6eb73dfb5 successfully ran local tests
tcharding:
ACK fa0c086431c9fc6ee872d6a14feccee6eb73dfb5
Tree-SHA512: 2b4f448c69d51ca8bf66110a46aa3a846cc47dc137b67f04643ae01a181f7208508c6af27429e26b3ee5d625c37923adc7fd20ccca701b5f5433b5a62d41a802
william2332-limf
added a commit
to william2332-limf/rust-secp256k1
that referenced
this pull request
Oct 2, 2025
fa0c086431c9fc6ee872d6a14feccee6eb73dfb5 refactor: recoveryid into enum (Liam Aharon)
Pull request description:
Closes #727
- Refactors `RecoveryId` into an enum.
- Replaces custom type methods `from_i32` and `to_i32` with `TryFrom<i32>` and `Into<i32>` (via `From<RecoveryId> for i32`) implementations.
- Removes derive `Ord` `PartialOrd` and `Hash`, they don't appear to be used. I can implement on the enum if we want to keep them.
ACKs for top commit:
apoelstra:
ACK fa0c086431c9fc6ee872d6a14feccee6eb73dfb5 successfully ran local tests
tcharding:
ACK fa0c086431c9fc6ee872d6a14feccee6eb73dfb5
Tree-SHA512: 2b4f448c69d51ca8bf66110a46aa3a846cc47dc137b67f04643ae01a181f7208508c6af27429e26b3ee5d625c37923adc7fd20ccca701b5f5433b5a62d41a802
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #727
RecoveryIdinto an enum.from_i32andto_i32withTryFrom<i32>andInto<i32>(viaFrom<RecoveryId> for i32) implementations.OrdPartialOrdandHash, they don't appear to be used. I can implement on the enum if we want to keep them.