Skip to content

Conversation

@witter-deland
Copy link
Contributor

@witter-deland witter-deland commented Nov 3, 2024

@apoelstra
Copy link
Member

In be017c2:

There is trailing whitespace on multiple lines.

But concept ACK.

@witter-deland witter-deland force-pushed the master branch 2 times, most recently from f3333cd to 9f75b63 Compare November 3, 2024 15:15
@witter-deland
Copy link
Contributor Author

fixed :)

In be017c2:

There is trailing whitespace on multiple lines.

But concept ACK.

@apoelstra
Copy link
Member

In 9f75b63:

There is still a trailing space on line 1017 :)

@witter-deland
Copy link
Contributor Author

fixed :)

In 9f75b63:

There is still a trailing space on line 1017 :)

@apoelstra
Copy link
Member

Please squash these commits.

@witter-deland
Copy link
Contributor Author

Done, thank you for your patience

Please squash these commits.

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2d29116; successfully ran local tests; thanks for iterating!

@apoelstra apoelstra merged commit 2bfda46 into rust-bitcoin:master Nov 3, 2024
29 of 30 checks passed
chain-forgexcr45 added a commit to chain-forgexcr45/rust-secp256k1 that referenced this pull request Sep 28, 2025
…rand for Keypair

2d29116fc9d53d7201a4fe4223eded9501bf3fa9 feat: add sign_schnorr_no_aux_rand for Keypair (Witter)

Pull request description:

  #761
  kaspanet/rusty-kaspa#586

ACKs for top commit:
  apoelstra:
    ACK 2d29116fc9d53d7201a4fe4223eded9501bf3fa9; successfully ran local tests; thanks for iterating!

Tree-SHA512: 29556e315a2f046cb845bc625686ffa3151feee66e988912d026dcc994eb13b567063c246e4aa4e37f057fa01a94cd18443cb3fc1fd80f470ad34e59f6fe600f
william2332-limf added a commit to william2332-limf/rust-secp256k1 that referenced this pull request Oct 2, 2025
…rand for Keypair

2d29116fc9d53d7201a4fe4223eded9501bf3fa9 feat: add sign_schnorr_no_aux_rand for Keypair (Witter)

Pull request description:

  #761
  kaspanet/rusty-kaspa#586

ACKs for top commit:
  apoelstra:
    ACK 2d29116fc9d53d7201a4fe4223eded9501bf3fa9; successfully ran local tests; thanks for iterating!

Tree-SHA512: 29556e315a2f046cb845bc625686ffa3151feee66e988912d026dcc994eb13b567063c246e4aa4e37f057fa01a94cd18443cb3fc1fd80f470ad34e59f6fe600f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants