-
Notifications
You must be signed in to change notification settings - Fork 305
Update the secp256k1-sys codebase to version v0.6.
#764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for doing this! Before running the vendor script, can you update the version in secp256k1-sys/Cargo.toml from 0.10.0 to 0.11.0? We need to update the version in order to make this releaseable, and because our vendoring code embeds the full version into all the symbols, and changing the name of these symbols is a breaking change, we don't have the ability to do minor bumps. Could you also add an initial commit to this PR which edits secp256k1-sys/vendor-libsecp.sh to remove the patch version from I don't know why I didn't think to do this years ago.. |
f29418e to
c3ef482
Compare
|
@apoelstra thanks. I added two new initial commits. |
|
Can you also update the Cargo-recent.lock and Cargo-minimal.lock files in the repo? |
|
That should get CI passing -- then I can test the last commit and ACK it -- and then I'll ask you to squash everything, even though your change are logically separate and nicely separated. Because unfortunately none of the changes work without the others. |
|
@apoelstra done. Thanks |
|
I had squashed everything, but then I realized you asked to do it after the review. |
|
utACK 0cdc758a56360bf58a851fe91085a327ec97685a Thanks for iterating!! If you squash everything I can do a tested ACK and merge it. (I already tested the tip so it will pass after squashing.) |
|
Err, utack 32a533c I mean. Copied the wrong commit. |
|
Thanks for reviewing. All commits squashed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 06ab8d0; successfully ran local tests; thanks for iterating!
…ebase to version v0.6. 06ab8d0c1eb1c450f5e3f49aff3b2de6ce7eaa39 Update codebase to version 0.6 (jlest01) Pull request description: This PR updates the `secp256k1-sys` codebase to version v0.6. I'm not sure if there are more steps involved, but these commits work fine in rust-bitcoin/rust-secp256k1#716. ACKs for top commit: apoelstra: ACK 06ab8d0c1eb1c450f5e3f49aff3b2de6ce7eaa39; successfully ran local tests; thanks for iterating! Tree-SHA512: 9b17a977d000821b7044f3f1f1b7d1e3209197be270b1e6a577c9245e30f09c6d6c532c85ffae5df503bc2ce80ea0c79983bbe7f838d77efac79f022132409c2
…ebase to version v0.6. 06ab8d0c1eb1c450f5e3f49aff3b2de6ce7eaa39 Update codebase to version 0.6 (jlest01) Pull request description: This PR updates the `secp256k1-sys` codebase to version v0.6. I'm not sure if there are more steps involved, but these commits work fine in rust-bitcoin/rust-secp256k1#716. ACKs for top commit: apoelstra: ACK 06ab8d0c1eb1c450f5e3f49aff3b2de6ce7eaa39; successfully ran local tests; thanks for iterating! Tree-SHA512: 9b17a977d000821b7044f3f1f1b7d1e3209197be270b1e6a577c9245e30f09c6d6c532c85ffae5df503bc2ce80ea0c79983bbe7f838d77efac79f022132409c2
This PR updates the
secp256k1-syscodebase to version v0.6.I'm not sure if there are more steps involved, but these commits work fine in #716.