test: Verify negative indices

Author: epage

tests/testsuite/errors.rs

@@ -3,6 +3,53 @@ use snapbox::{assert_data_eq, str};
 
 use config::{Config, ConfigError, File, FileFormat, Map, Value};
 
+#[test]
+#[cfg(feature = "json")]
+fn test_error_path_index_bounds() {
+    let c = Config::builder()
+        .add_source(File::from_str(
+            r#"
+{
+  "arr": [1]
+}
+"#,
+            FileFormat::Json,
+        ))
+        .build()
+        .unwrap();
+
+    let res = c.get::<usize>("arr[2]");
+    assert!(res.is_err());
+    assert_data_eq!(
+        res.unwrap_err().to_string(),
+        str![[r#"configuration property "arr[2]" not found"#]]
+    );
+}
+
+#[test]
+#[cfg(feature = "json")]
+#[should_panic]
+fn test_error_path_index_negative_bounds() {
+    let c = Config::builder()
+        .add_source(File::from_str(
+            r#"
+{
+  "arr": []
+}
+"#,
+            FileFormat::Json,
+        ))
+        .build()
+        .unwrap();
+
+    let res = c.get::<usize>("arr[-1]");
+    assert!(res.is_err());
+    assert_data_eq!(
+        res.unwrap_err().to_string(),
+        str![[r#"configuration property "arr[2]" not found"#]]
+    );
+}
+
 #[test]
 #[cfg(feature = "json")]
 fn test_error_parse() {

tests/testsuite/set.rs

@@ -63,6 +63,7 @@ fn test_set_scalar_path() {
 
 #[test]
 #[cfg(feature = "json")]
+#[should_panic]
 fn test_set_arr_path() {
     let config = Config::builder()
         .set_override("present[0].name", "Ivan")
@@ -79,6 +80,10 @@ fn test_set_arr_path() {
         .unwrap()
         .set_override("reverse[-2]", "Alice")
         .unwrap()
+        .set_override("empty[-1]", "Bob")
+        .unwrap()
+        .set_override("empty[-2]", "Alice")
+        .unwrap()
         .add_source(File::from_str(
             r#"
 {
@@ -97,7 +102,8 @@ fn test_set_arr_path() {
     {
       "name": "l2"
     }
-  ]
+  ],
+  "empty": []
 }
 "#,
             FileFormat::Json,
@@ -115,6 +121,8 @@ fn test_set_arr_path() {
     assert_eq!(config.get("present[2]").ok(), Some("George".to_owned()));
     assert_eq!(config.get("reverse[1]").ok(), Some("Bob".to_owned()));
     assert_eq!(config.get("reverse[0]").ok(), Some("Alice".to_owned()));
+    assert_eq!(config.get("empty[1]").ok(), Some("Bob".to_owned()));
+    assert_eq!(config.get("empty[0]").ok(), Some("Alice".to_owned()));
 }
 
 #[test]