refactor: ini format parser
#470
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasbeyer
requested changes
Oct 6, 2023
matthiasbeyer
requested changes
Oct 6, 2023
polarathene
commented
Oct 6, 2023
Intended to be easier to grok and match the same flow as other format parsers. Signed-off-by: Brennan Kinney <[email protected]>
Signed-off-by: Brennan Kinney <[email protected]>
Signed-off-by: Brennan Kinney <[email protected]>
polarathene
force-pushed
the
refactor/format-ini-parser
branch
from
db2f74a to
ff60fb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to be easier to grok and match the same flow as other format parsers.
I worked on this after #469 , but my main gripes were with the
secnot being obvious that it was referencing a section, and the repeated inner loop for building property maps.I added the same enum check with the final
Tablemap wrapped inValuelike other parsers, although for this that may be redundant and could be dropped?Not too fussed if you want to reject this. I originally envisioned it looking nicer than it turned out 😅