Skip to content

Commit 3af9830

Browse files
committed
Fix Uncaught ReferenceError: hideMenu is not defined
cc #207
1 parent 6579ccf commit 3af9830

File tree

3 files changed

+29
-25
lines changed

3 files changed

+29
-25
lines changed

static/menus.js

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ export class Menu extends React.Component {
2020
}
2121

2222
didRender() {
23-
console.log("menu didRender")
2423
if (this.items().length == 0) {
2524
this.props.onClose();
2625
return;
@@ -31,35 +30,35 @@ export class Menu extends React.Component {
3130
}
3231

3332
items() {
33+
const self = this;
3434
return this.props
3535
.items
3636
.filter((i) => { return !i.unstable || CONFIG.unstable_features })
3737
.map((i) => {
3838
const className = `${this.props.id}_link menu_link`;
3939
let onClick = (ev) => {
40-
hideMenu(ev);
40+
self.hideMenu(ev);
4141
i.fn(self.props.target, self.props.location);
4242
};
4343
return <div className={className} id={i.id} key={i.id} onClick={onClick}>{i.label}</div>;
4444
});
4545
}
4646

47-
render() {
48-
const self = this;
49-
const hideMenu = (event) => {
50-
self.props.onClose();
51-
event.preventDefault();
52-
event.stopPropagation();
53-
};
47+
hideMenu(event) {
48+
this.props.onClose();
49+
event.preventDefault();
50+
event.stopPropagation();
51+
}
5452

53+
render() {
5554
let items = this.items();
5655

5756
if (items.length === 0) {
5857
return null;
5958
}
6059

6160
return <span>
62-
<div id="div_overlay" onClick={hideMenu} />
61+
<div id="div_overlay" onClick={(ev) => this.hideMenu(ev) } />
6362
<div id={this.props.id} className="div_menu">
6463
{items}
6564
</div>

static/rustw.out.js

Lines changed: 19 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -6744,12 +6744,13 @@ var Menu = exports.Menu = function (_React$Component) {
67446744
value: function items() {
67456745
var _this2 = this;
67466746

6747+
var self = this;
67476748
return this.props.items.filter(function (i) {
67486749
return !i.unstable || CONFIG.unstable_features;
67496750
}).map(function (i) {
67506751
var className = _this2.props.id + "_link menu_link";
67516752
var onClick = function onClick(ev) {
6752-
hideMenu(ev);
6753+
self.hideMenu(ev);
67536754
i.fn(self.props.target, self.props.location);
67546755
};
67556756
return _react2.default.createElement(
@@ -6759,15 +6760,17 @@ var Menu = exports.Menu = function (_React$Component) {
67596760
);
67606761
});
67616762
}
6763+
}, {
6764+
key: "hideMenu",
6765+
value: function hideMenu(event) {
6766+
this.props.onClose();
6767+
event.preventDefault();
6768+
event.stopPropagation();
6769+
}
67626770
}, {
67636771
key: "render",
67646772
value: function render() {
6765-
var self = this;
6766-
var hideMenu = function hideMenu(event) {
6767-
self.props.onClose();
6768-
event.preventDefault();
6769-
event.stopPropagation();
6770-
};
6773+
var _this3 = this;
67716774

67726775
var items = this.items();
67736776

@@ -6778,7 +6781,9 @@ var Menu = exports.Menu = function (_React$Component) {
67786781
return _react2.default.createElement(
67796782
"span",
67806783
null,
6781-
_react2.default.createElement("div", { id: "div_overlay", onClick: hideMenu }),
6784+
_react2.default.createElement("div", { id: "div_overlay", onClick: function onClick(ev) {
6785+
return _this3.hideMenu(ev);
6786+
} }),
67826787
_react2.default.createElement(
67836788
"div",
67846789
{ id: this.props.id, className: "div_menu" },
@@ -6797,27 +6802,27 @@ var MenuHost = exports.MenuHost = function (_React$Component2) {
67976802
function MenuHost(props) {
67986803
_classCallCheck(this, MenuHost);
67996804

6800-
var _this3 = _possibleConstructorReturn(this, (MenuHost.__proto__ || Object.getPrototypeOf(MenuHost)).call(this, props));
6805+
var _this4 = _possibleConstructorReturn(this, (MenuHost.__proto__ || Object.getPrototypeOf(MenuHost)).call(this, props));
68016806

6802-
_this3.state = { menuOpen: null };
6803-
return _this3;
6807+
_this4.state = { menuOpen: null };
6808+
return _this4;
68046809
}
68056810

68066811
_createClass(MenuHost, [{
68076812
key: "render",
68086813
value: function render() {
6809-
var _this4 = this;
6814+
var _this5 = this;
68106815

68116816
var menu = null;
68126817
if (!!this.state.menuOpen) {
68136818
var onClose = function onClose() {
6814-
return _this4.setState({ menuOpen: null });
6819+
return _this5.setState({ menuOpen: null });
68156820
};
68166821
menu = _react2.default.createElement(this.menuFn, { location: this.state.menuOpen, onClose: onClose, target: this.state.menuOpen.target, callbacks: this.props.callbacks });
68176822
}
68186823

68196824
var contextMenu = function contextMenu(ev) {
6820-
_this4.setState({ menuOpen: { "top": ev.pageY, "left": ev.pageX, target: ev.target } });
6825+
_this5.setState({ menuOpen: { "top": ev.pageY, "left": ev.pageX, target: ev.target } });
68216826
ev.preventDefault();
68226827
ev.stopPropagation();
68236828
};

static/rustw.out.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)