fix clippy errors

fix all errors reported by `cargo clippy`.

Author: rursprung

src/bluefruit_protocol/button_event.rs

@@ -32,7 +32,7 @@ impl Button {
             b'6' => Ok(Button::Down),
             b'7' => Ok(Button::Left),
             b'8' => Ok(Button::Right),
-            _ => Err(ButtonParseError::UnknownButton(input.clone())),
+            _ => Err(ButtonParseError::UnknownButton(*input)),
         }
     }
 }
@@ -50,7 +50,7 @@ impl ButtonState {
         match input {
             b'0' => Ok(ButtonState::Released),
             b'1' => Ok(ButtonState::Pressed),
-            _ => Err(ButtonParseError::UnknownButtonState(input.clone())),
+            _ => Err(ButtonParseError::UnknownButtonState(*input)),
         }
     }
 }
@@ -74,10 +74,9 @@ impl TryFrom<&[u8]> for ButtonEvent {
             Err(ProtocolParseError::InvalidLength(expected_len, input.len()))
         } else {
             Ok(ButtonEvent {
-                button: Button::from_id(&input[0])
-                    .map_err(|e| ProtocolParseError::ButtonParseError(e))?,
+                button: Button::from_id(&input[0]).map_err(ProtocolParseError::ButtonParseError)?,
                 state: ButtonState::from_id(&input[1])
-                    .map_err(|e| ProtocolParseError::ButtonParseError(e))?,
+                    .map_err(ProtocolParseError::ButtonParseError)?,
             })
         }
     }

src/bluefruit_protocol/mod.rs

@@ -61,7 +61,7 @@ pub const MAX_CONTROLLER_MESSAGE_LENGTH: usize = 32; // give slightly more than
 
 impl ControllerDataPackageType {
     /// Returns the length of the data section of the command.
-    fn data_len(self: &Self) -> usize {
+    fn data_len(&self) -> usize {
         match self {
             ControllerDataPackageType::ButtonCommand => 2,
             ControllerDataPackageType::Color => 3,
@@ -123,7 +123,7 @@ pub fn parse<const MAX_RESULTS: usize>(
         };
     }
 
-    return result;
+    result
 }
 
 /// Extract a command and then try to parse it.
@@ -162,25 +162,25 @@ fn parse_command(
     let data = &command_input[data_start..=data_end];
     match command {
         ControllerDataPackageType::ButtonCommand => {
-            ButtonEvent::try_from(data).map(|evt| ControllerEvent::ButtonEvent(evt))
+            ButtonEvent::try_from(data).map(ControllerEvent::ButtonEvent)
         }
         ControllerDataPackageType::Color => {
-            ColorEvent::try_from(data).map(|evt| ControllerEvent::ColorEvent(evt))
+            ColorEvent::try_from(data).map(ControllerEvent::ColorEvent)
         }
         ControllerDataPackageType::Quaternion => {
-            QuaternionEvent::try_from(data).map(|evt| ControllerEvent::QuaternionEvent(evt))
+            QuaternionEvent::try_from(data).map(ControllerEvent::QuaternionEvent)
         }
         ControllerDataPackageType::Accelerometer => {
-            AccelerometerEvent::try_from(data).map(|evt| ControllerEvent::AccelerometerEvent(evt))
+            AccelerometerEvent::try_from(data).map(ControllerEvent::AccelerometerEvent)
         }
         ControllerDataPackageType::Gyro => {
-            GyroEvent::try_from(data).map(|evt| ControllerEvent::GyroEvent(evt))
+            GyroEvent::try_from(data).map(ControllerEvent::GyroEvent)
         }
         ControllerDataPackageType::Magnetometer => {
-            MagnetometerEvent::try_from(data).map(|evt| ControllerEvent::MagnetometerEvent(evt))
+            MagnetometerEvent::try_from(data).map(ControllerEvent::MagnetometerEvent)
         }
         ControllerDataPackageType::Location => {
-            LocationEvent::try_from(data).map(|evt| ControllerEvent::LocationEvent(evt))
+            LocationEvent::try_from(data).map(ControllerEvent::LocationEvent)
         }
     }
 }

src/lib.rs

@@ -43,7 +43,7 @@ impl BluefruitLEUARTFriend {
             serial::Config::default()
                 .baudrate(9600.bps())
                 .dma(serial::config::DmaConfig::Rx),
-            &clocks,
+            clocks,
         )
         .expect("USART1 can be set up");