clippy auto fix but some more should be polished

Author: BL-CZY

src/fat/volume.rs

@@ -623,7 +623,7 @@ impl FatVolume {
                         lfn_buffer.push(&buffer);
                         SeqState::Complete { csum }
                     }
-                    (true, sequence, _) if sequence >= 0x02 && sequence < 0x14 => {
+                    (true, sequence, _) if (0x02..0x14).contains(&sequence) => {
                         lfn_buffer.clear();
                         lfn_buffer.push(&buffer);
                         SeqState::Remaining {
@@ -636,7 +636,7 @@ impl FatVolume {
                         SeqState::Complete { csum }
                     }
                     (false, sequence, SeqState::Remaining { csum, next })
-                        if sequence >= 0x01 && sequence < 0x13 && next == sequence =>
+                        if (0x01..0x13).contains(&sequence) && next == sequence =>
                     {
                         lfn_buffer.push(&buffer);
                         SeqState::Remaining {
@@ -796,10 +796,7 @@ impl FatVolume {
                     }
                 }
             }
-            current_cluster = match self.next_cluster(block_cache, cluster).await {
-                Ok(n) => Some(n),
-                _ => None,
-            };
+            current_cluster = (self.next_cluster(block_cache, cluster).await).ok();
         }
         Ok(())
     }
@@ -876,10 +873,7 @@ impl FatVolume {
                             x => return x,
                         }
                     }
-                    current_cluster = match self.next_cluster(block_cache, cluster).await {
-                        Ok(n) => Some(n),
-                        _ => None,
-                    }
+                    current_cluster = (self.next_cluster(block_cache, cluster).await).ok()
                 }
                 Err(Error::NotFound)
             }
@@ -1014,10 +1008,7 @@ impl FatVolume {
                         }
                     }
                     // Find the next cluster
-                    current_cluster = match self.next_cluster(block_cache, cluster).await {
-                        Ok(n) => Some(n),
-                        _ => None,
-                    }
+                    current_cluster = (self.next_cluster(block_cache, cluster).await).ok()
                 }
                 // Ok, give up
             }
@@ -1432,9 +1423,7 @@ where
                 return Err(Error::BadBlockSize(bpb.bytes_per_block()));
             }
             // FirstDataSector = BPB_ResvdSecCnt + (BPB_NumFATs * FATSz) + RootDirSectors;
-            let root_dir_blocks = ((u32::from(bpb.root_entries_count()) * OnDiskDirEntry::LEN_U32)
-                + (Block::LEN_U32 - 1))
-                / Block::LEN_U32;
+            let root_dir_blocks = (u32::from(bpb.root_entries_count()) * OnDiskDirEntry::LEN_U32).div_ceil(Block::LEN_U32);
             let first_root_dir_block =
                 fat_start + BlockCount(u32::from(bpb.num_fats()) * bpb.fat_size());
             let first_data_block = first_root_dir_block + BlockCount(root_dir_blocks);

src/volume_mgr.rs

@@ -767,7 +767,7 @@ where
                 if maybe_volume_name.is_none()
                     && de.attributes == Attributes::create_from_fat(Attributes::VOLUME)
                 {
-                    maybe_volume_name = Some(unsafe { de.name.clone().to_volume_label() })
+                    maybe_volume_name = Some(unsafe { de.name.to_volume_label() })
                 }
             })
             .await?;