Merge pull request #74 from diondokter/Release-async-v0.4.2 #134
Annotations
11 warnings
|
hiding a lifetime that's named elsewhere is confusing:
src/iter.rs#L54
warning: hiding a lifetime that's named elsewhere is confusing
--> src/iter.rs:54:60
|
54 | fn overlaps(self, memory: &'a [u8], base_address: u32) -> OverlapIterator<R, I> {
| -- the lifetime is named here ^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here
|
= help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: consistently use `'a`
|
54 | fn overlaps(self, memory: &'a [u8], base_address: u32) -> OverlapIterator<'a, R, I> {
| +++
|
|
hiding a lifetime that's named elsewhere is confusing:
src/iter.rs#L22
warning: hiding a lifetime that's named elsewhere is confusing
--> src/iter.rs:22:60
|
22 | fn overlaps(self, memory: &'a [u8], base_address: u32) -> OverlapIterator<R, I>;
| -- the lifetime is named here ^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here
|
= help: the same lifetime is referred to in inconsistent ways, making the signature confusing
= note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
help: consistently use `'a`
|
22 | fn overlaps(self, memory: &'a [u8], base_address: u32) -> OverlapIterator<'a, R, I>;
| +++
|
|
empty doc comment:
src/nor_flash.rs#L293
warning: empty doc comment
--> src/nor_flash.rs:293:1
|
293 | ///
| ^^^
|
= help: consider removing or filling it
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#empty_docs
|
|
empty doc comment:
src/nor_flash.rs#L218
warning: empty doc comment
--> src/nor_flash.rs:218:1
|
218 | ///
| ^^^
|
= help: consider removing or filling it
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#empty_docs
= note: `#[warn(clippy::empty_docs)]` on by default
|
|
manual implementation of `.is_multiple_of()`:
src/nor_flash.rs#L146
warning: manual implementation of `.is_multiple_of()`
--> src/nor_flash.rs:146:28
|
146 | if offset % align != 0 || length % align != 0 {
| ^^^^^^^^^^^^^^^^^^^ help: replace with: `!length.is_multiple_of(align)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#manual_is_multiple_of
|
|
manual implementation of `.is_multiple_of()`:
src/nor_flash.rs#L146
warning: manual implementation of `.is_multiple_of()`
--> src/nor_flash.rs:146:5
|
146 | if offset % align != 0 || length % align != 0 {
| ^^^^^^^^^^^^^^^^^^^ help: replace with: `!offset.is_multiple_of(align)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#manual_is_multiple_of
= note: `#[warn(clippy::manual_is_multiple_of)]` on by default
|
|
this loop could be written as a `for` loop:
src/iter.rs#L35
warning: this loop could be written as a `for` loop
--> src/iter.rs:35:3
|
35 | while let Some(region) = self.regions.next() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for region in self.regions.by_ref()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#while_let_on_iterator
= note: `#[warn(clippy::while_let_on_iterator)]` on by default
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|