Rename inherent clear, optimize DrawTarget::clear

Author: bugadani

CHANGELOG.md

@@ -19,7 +19,7 @@
 - **(breaking)** [#184](https://github.com/jamwaffles/ssd1306/pull/184) Increased MSRV to 1.61.0
 - **(breaking)** [#179](https://github.com/jamwaffles/ssd1306/pull/179) Changed `Ssd1306::reset` signature.
 - [#181](https://github.com/jamwaffles/ssd1306/pull/181) Update embedded-graphics-core dependency to 0.4
-- **(breaking)** [#182](https://github.com/jamwaffles/ssd1306/pull/182) The inherent `BufferedGraphicsMode::clear` is no longer available when the `graphics` feature is enabled.
+- **(breaking)** [#18?](https://github.com/jamwaffles/ssd1306/pull/18?) The inherent `BufferedGraphicsMode::clear` has been renamed to `clear_buffer`.
 
 ## [0.7.1] - 2022-08-15
 

src/mode/buffered_graphics.rs

@@ -68,12 +68,8 @@ where
     DI: WriteOnlyDataCommand,
     SIZE: DisplaySize,
 {
-    /// Clear the display buffer. You need to call `disp.flush()` for any effect on the screen
-    #[cfg(not(feature = "graphics"))]
-    pub fn clear(&mut self) {
-        for b in self.mode.buffer.as_mut() {
-            *b = 0;
-        }
+    fn clear_impl(&mut self, value: bool) {
+        self.mode.buffer.as_mut().fill(value as u8);
 
         let (width, height) = self.dimensions();
         self.mode.min_x = 0;
@@ -82,6 +78,11 @@ where
         self.mode.max_y = height - 1;
     }
 
+    /// Clear the underlying framebuffer. You need to call `disp.flush()` for any effect on the screen.
+    pub fn clear_buffer(&mut self) {
+        self.clear_impl(false);
+    }
+
     /// Write out data to a display.
     ///
     /// This only updates the parts of the display that have changed since the last flush.
@@ -226,6 +227,11 @@ where
 
         Ok(())
     }
+
+    fn clear(&mut self, color: Self::Color) -> Result<(), Self::Error> {
+        self.clear_impl(color.is_on());
+        Ok(())
+    }
 }
 
 #[cfg(feature = "graphics")]