Improve clippy coverage

Author: ithinuel

.github/workflows/rustfmt.yml

@@ -16,3 +16,6 @@ jobs:
           components: rustfmt
       - run: cargo fmt --all -- --check
       - run: cargo clippy --all-features
+      - run: cargo clippy --features defmt
+      - run: cargo clippy --features control-buffer-256
+      - run: cargo clippy

src/descriptor/lang_id.rs

@@ -349,7 +349,7 @@ pub enum LangID {
     MN_MONG_MN = 0x0C50,
     DZ_BT = 0x0C51,
     TMZ_MA = 0x0C5F,
-    QUZ_PE = 0x0C6b,
+    QUZ_PE = 0x0C6B,
     LOCALE_CUSTOM_UNSPECIFIED = 0x1000,
     AR_LY = 0x1001,
     ZH_SG = 0x1004,

src/device.rs

@@ -606,32 +606,28 @@ impl<B: UsbBus> UsbDevice<'_, B> {
                                     }
                                 };
 
-                                lang_id_list
-                                    .iter()
-                                    .fuse()
-                                    .position(|list_lang_id| match *list_lang_id {
-                                        Some(list_lang_id) if req_lang_id == list_lang_id => true,
-                                        _ => false,
-                                    })
-                                    .or_else(|| {
-                                        // Since we construct the list of full supported lang_ids previously,
-                                        // we can safely reject requests which ask for other lang_id.
-                                        #[cfg(feature = "defmt")]
-                                        defmt::warn!(
-                                            "Receive unknown LANGID {:#06X}, reject the request",
-                                            req_lang_id
-                                        );
-                                        None
-                                    })
-                                    .and_then(|lang_id_list_index| {
-                                        match index {
-                                            1 => config.manufacturer,
-                                            2 => config.product,
-                                            3 => config.serial_number,
-                                            _ => unreachable!(),
-                                        }
-                                        .map(|str_list| str_list[lang_id_list_index])
-                                    })
+                                let position =
+                                    lang_id_list.iter().fuse().position(|list_lang_id| {
+                                        matches!(*list_lang_id, Some(list_lang_id) if req_lang_id == list_lang_id)
+                                    });
+                                #[cfg(feature = "defmt")]
+                                if position.is_none() {
+                                    // Since we construct the list of full supported lang_ids previously,
+                                    // we can safely reject requests which ask for other lang_id.
+                                    defmt::warn!(
+                                        "Receive unknown LANGID {:#06X}, reject the request",
+                                        req_lang_id
+                                    );
+                                }
+                                position.and_then(|lang_id_list_index| {
+                                    match index {
+                                        1 => config.manufacturer,
+                                        2 => config.product,
+                                        3 => config.serial_number,
+                                        _ => unreachable!(),
+                                    }
+                                    .map(|str_list| str_list[lang_id_list_index])
+                                })
                             } else {
                                 // for other custom STRINGs
 

src/device_builder.rs

@@ -114,7 +114,7 @@ impl<'a, B: UsbBus> UsbDeviceBuilder<'a, B> {
     ///
     /// Default: (none)
     pub fn set_extra_lang_ids(mut self, extra_lang_ids: &'a [LangID]) -> Self {
-        if extra_lang_ids.len() == 0 {
+        if extra_lang_ids.is_empty() {
             self.config.extra_lang_ids = None;
             return self;
         }
@@ -154,7 +154,7 @@ impl<'a, B: UsbBus> UsbDeviceBuilder<'a, B> {
     ///
     /// Default: (none)
     pub fn manufacturer(mut self, manufacturer_ls: &'a [&'a str]) -> Self {
-        if manufacturer_ls.len() == 0 {
+        if manufacturer_ls.is_empty() {
             self.config.manufacturer = None;
             return self;
         }
@@ -184,7 +184,7 @@ impl<'a, B: UsbBus> UsbDeviceBuilder<'a, B> {
     ///
     /// Default: (none)
     pub fn product(mut self, product_ls: &'a [&'a str]) -> Self {
-        if product_ls.len() == 0 {
+        if product_ls.is_empty() {
             self.config.product = None;
             return self;
         }
@@ -214,7 +214,7 @@ impl<'a, B: UsbBus> UsbDeviceBuilder<'a, B> {
     ///
     /// Default: (none)
     pub fn serial_number(mut self, serial_number_ls: &'a [&'a str]) -> Self {
-        if serial_number_ls.len() == 0 {
+        if serial_number_ls.is_empty() {
             self.config.serial_number = None;
             return self;
         }