Do not reexport definitions

Author: eldruin

src/digital.rs

@@ -11,7 +11,7 @@ use core::{convert::From, ops::Not};
 /// Conversion from `bool` and logical negation are also implemented
 /// for this type.
 /// ```rust
-/// # use embedded_hal::digital::blocking::PinState;
+/// # use embedded_hal::digital::PinState;
 /// let state = PinState::from(false);
 /// assert_eq!(state, PinState::Low);
 /// assert_eq!(!state, PinState::High);
@@ -46,7 +46,7 @@ impl Not for PinState {
 
 /// Blocking digital I/O traits
 pub mod blocking {
-    pub use super::PinState;
+    use super::PinState;
 
     /// Single digital push-pull output pin
     pub trait OutputPin {

src/i2c.rs

@@ -26,7 +26,7 @@
 //! Here is an example of an embedded-hal implementation of the `Write` trait
 //! for both modes:
 //! ```
-//! # use embedded_hal::i2c::blocking::{SevenBitAddress, TenBitAddress, Write};
+//! # use embedded_hal::i2c::{SevenBitAddress, TenBitAddress, blocking::Write};
 //! /// I2C0 hardware peripheral which supports both 7-bit and 10-bit addressing.
 //! pub struct I2c0;
 //!
@@ -79,7 +79,7 @@
 //! ### Device driver compatible only with 10-bit addresses
 //!
 //! ```
-//! # use embedded_hal::i2c::blocking::{TenBitAddress, WriteRead};
+//! # use embedded_hal::i2c::{TenBitAddress, blocking::WriteRead};
 //! const ADDR: u16  = 0x158;
 //! # const TEMP_REGISTER: u8 = 0x1;
 //! pub struct TemperatureSensorDriver<I2C> {
@@ -119,7 +119,7 @@ impl AddressMode for TenBitAddress {}
 /// Blocking I2C traits
 pub mod blocking {
 
-    pub use super::{AddressMode, SevenBitAddress, TenBitAddress};
+    use super::{AddressMode, SevenBitAddress};
 
     /// Blocking read
     pub trait Read<A: AddressMode = SevenBitAddress> {

src/qei.rs

@@ -11,7 +11,7 @@ pub enum Direction {
 
 /// Blocking quadrature encoder interface traits
 pub mod blocking {
-    pub use super::Direction;
+    use super::Direction;
 
     /// Quadrature encoder interface
     ///
@@ -56,7 +56,7 @@ pub mod blocking {
     /// #     type Error = Infallible;
     /// #     type Count = u16;
     /// #     fn count(&self) -> Result<u16, Self::Error> { Ok(0) }
-    /// #     fn direction(&self) -> Result<::hal::qei::blocking::Direction, Self::Error> { unimplemented!() }
+    /// #     fn direction(&self) -> Result<::hal::qei::Direction, Self::Error> { unimplemented!() }
     /// # }
     /// # struct Timer6;
     /// # impl hal::timer::nb::CountDown for Timer6 {

src/spi/blocking.rs

@@ -4,7 +4,6 @@
 //! traits. To save boilerplate when that's the case a `Default` marker trait may be provided.
 //! Implementing that marker trait will opt in your type into a blanket implementation.
 
-pub use super::{Mode, Phase, Polarity, MODE_0, MODE_1, MODE_2, MODE_3};
 /// Blocking transfer
 pub trait Transfer<W> {
     /// Error type

src/spi/nb.rs

@@ -1,7 +1,5 @@
 //! Serial Peripheral Interface
 
-pub use super::{Mode, Phase, Polarity, MODE_0, MODE_1, MODE_2, MODE_3};
-
 /// Full duplex (master mode)
 ///
 /// # Notes

src/timer.rs

@@ -5,7 +5,6 @@ pub trait Periodic {}
 
 /// Non-blocking timer traits
 pub mod nb {
-    pub use super::Periodic;
 
     /// A count down timer
     ///