Merge #393

393: Remove IoPin r=eldruin a=Dirbaio

As discussed in #340 it's unclear if the current IoPin trait is the best way to go (tldr: due to the fact it changes type it's hard to own it in driver structs).

I propose temporarily removing it, to unblock the 1.0 release. When discussion settles on a final design, we can add it back.

Co-authored-by: Dario Nieuwenhuis <[email protected]>

Author: bors[bot]

CHANGELOG.md

@@ -13,6 +13,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 ### Fixed
 - Fixed documentation for `wait_for_rising_edge`.
 
+### Removed
+- `digital::blocking::IoPin` traits.
+
 ## [v1.0.0-alpha.8] - 2022-04-15
 
 *** This is (also) an alpha release with breaking changes (sorry) ***

src/digital.rs

@@ -152,50 +152,4 @@ pub mod blocking {
             T::is_low(self)
         }
     }
-
-    /// Single pin that can switch from input to output mode, and vice-versa.
-    ///
-    /// Example use (assumes the `Error` type is the same for the `IoPin`,
-    /// `InputPin`, and `OutputPin`):
-    ///
-    /// ```
-    /// use core::time::Duration;
-    /// use embedded_hal::digital::blocking::{IoPin, InputPin, OutputPin};
-    ///
-    /// pub fn ping_and_read<TInputPin, TOutputPin, TError: core::fmt::Debug>(
-    ///     mut pin: TOutputPin, delay_fn: &dyn Fn(Duration) -> ()) -> Result<bool, TError>
-    /// where
-    ///     TInputPin : InputPin<Error = TError> + IoPin<TInputPin, TOutputPin, Error = TError>,
-    ///     TOutputPin : OutputPin<Error = TError> + IoPin<TInputPin, TOutputPin, Error = TError>,
-    /// {
-    ///     // Ping
-    ///     pin.set_low()?;
-    ///     delay_fn(Duration::from_millis(10));
-    ///     pin.set_high()?;
-    ///
-    ///     // Read
-    ///     let pin = pin.into_input_pin()?;
-    ///     delay_fn(Duration::from_millis(10));
-    ///     pin.is_high()
-    /// }
-    /// ```
-    pub trait IoPin<TInput, TOutput>
-    where
-        TInput: InputPin + IoPin<TInput, TOutput>,
-        TOutput: OutputPin + IoPin<TInput, TOutput>,
-    {
-        /// Error type.
-        type Error: core::fmt::Debug;
-
-        /// Tries to convert this pin to input mode.
-        ///
-        /// If the pin is already in input mode, this method should succeed.
-        fn into_input_pin(self) -> Result<TInput, Self::Error>;
-
-        /// Tries to convert this pin to output mode with the given initial state.
-        ///
-        /// If the pin is already in the requested state, this method should
-        /// succeed.
-        fn into_output_pin(self, state: PinState) -> Result<TOutput, Self::Error>;
-    }
 }