From 45f6a64d5ef3bd5bd390811165255f1cbe602f36 Mon Sep 17 00:00:00 2001 From: Dario Nieuwenhuis Date: Mon, 14 Apr 2025 14:37:09 +0200 Subject: [PATCH] nb: do not swallow errors in fmt::Write. --- embedded-hal-nb/src/serial.rs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/embedded-hal-nb/src/serial.rs b/embedded-hal-nb/src/serial.rs index 6b4d7903..e51085cf 100644 --- a/embedded-hal-nb/src/serial.rs +++ b/embedded-hal-nb/src/serial.rs @@ -124,10 +124,9 @@ where { #[inline] fn write_str(&mut self, s: &str) -> core::fmt::Result { - let _ = s - .bytes() - .map(|c| nb::block!(self.write(Word::from(c)))) - .next_back(); + for c in s.bytes() { + nb::block!(self.write(Word::from(c))).map_err(|_| core::fmt::Error)?; + } Ok(()) } }