Propagate lower-level errors as sources for embedded_io error types. #712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands the
core::error::Errorimplementations for bothembedded_io::ReadExactErrorandembedded_io::WriteFmtErrorto implement thesource()function to return the underlying error contained in theOthervariant.Note that this changes the bounds for the
core::error::Errorimplementations to both types to requireE: core::error::Error + 'static, but in practice this shouldn't cause many issues since using bothRead::read_exact()andWrite::write_fmt()relies on theErrorTypetrait, which requires itsErrorto implementcore::error::Error. Technically this is a breaking change, and would possibly break places where someone is constructing these error types outside of the context of the io traits.