Merge #132

132: Update GitHub workflows r=almindor a=romancardenas

With all the bors thing going on, I've been reading a bit about merge queues etc. and noticed that some of our workflows still use outdated/deprecated actions. This PR fixes this.

Co-authored-by: Román Cárdenas <[email protected]>

Author: bors[bot]

.github/bors.toml

@@ -2,9 +2,7 @@ block_labels = ["needs-decision"]
 delete_merged_branches = true
 required_approvals = 1
 status = [
-    "ci-linux (stable)",
-    "ci-linux (1.59.0)",
-    "build-other (macOS-latest)",
-    "build-other (windows-latest)",
-    "Rustfmt"
+    "build-check",
+    "clippy-check",
+    "rustfmt",
 ]

.github/workflows/build.yaml

@@ -0,0 +1,62 @@
+on:
+  push:
+    branches: [ staging, trying, master ]
+  pull_request:
+  merge_group:
+
+name: Build check
+
+jobs:
+  # We check that the crate builds and links for all the toolchains and targets.
+  build-riscv:
+    strategy:
+      matrix:
+        # All generated code should be running on stable now, MRSV is 1.59.0
+        toolchain: [ stable, nightly, 1.59.0 ]
+        target:
+          - riscv32i-unknown-none-elf
+          - riscv32imc-unknown-none-elf
+          - riscv32imac-unknown-none-elf
+          - riscv64imac-unknown-none-elf
+          - riscv64gc-unknown-none-elf
+        cargo_flags: [ "--no-default-features", "--all-features" ]
+        include:
+          # Nightly is only for reference and allowed to fail
+          - toolchain: nightly
+            experimental: true
+    runs-on: ubuntu-latest
+    continue-on-error: ${{ matrix.experimental || false }}
+    steps:
+    - uses: actions/checkout@v3
+    - uses: dtolnay/rust-toolchain@master
+      with:
+        toolchain: ${{ matrix.toolchain }}
+        targets: ${{ matrix.target }}
+    - name: Build library
+      run: cargo build --target ${{ matrix.target }} ${{ matrix.cargo_flags }}
+      
+  # On MacOS, Ubuntu, and Windows, we at least make sure that the crate builds and links.
+  build-others:
+    strategy:
+      matrix:
+        os:
+          - macos-latest
+          - ubuntu-latest
+          - windows-latest
+        cargo_flags: [ "--no-default-features", "--all-features" ]
+    runs-on: ${{ matrix.os }}
+    steps:
+      - uses: actions/checkout@v3
+      - uses: dtolnay/rust-toolchain@stable
+      - name: Build crate for host OS
+        run: cargo build ${{ matrix.cargo_flags }}
+  
+  # Job to check that all the builds succeeded
+  build-check:
+    needs:
+    - build-riscv
+    - build-others
+    runs-on: ubuntu-latest
+    if: always()
+    steps:
+      - run: jq --exit-status 'all(.result == "success")' <<< '${{ toJson(needs) }}'

.github/workflows/ci.yaml

@@ -1,36 +1,42 @@
-name: Clippy
-
 on:
   push:
     branches: [ staging, trying, master ]
   pull_request:
-    branches: [ master ]
+  merge_group:
 
-defaults:
-  run:
-    shell: bash
+name: Lints compliance check
 
 env:
   CLIPPY_PARAMS: -W clippy::all -W clippy::pedantic -W clippy::nursery -W clippy::cargo
 
 jobs:
   clippy:
-    name: Clippy
-    runs-on: ubuntu-latest
     strategy:
       matrix:
+        toolchain: [ stable, nightly ]
         cargo_flags:
           - "--no-default-features"
           - "--all-features"
+        include:
+          # Nightly is only for reference and allowed to fail
+          - toolchain: nightly
+            experimental: true
+    runs-on: ubuntu-latest
+    continue-on-error: ${{ matrix.experimental || false }}
     steps:
-      - name: Checkout source code
-        uses: actions/checkout@v3
-
-      - name: Install Rust toolchain
-        uses: dtolnay/rust-toolchain@stable
+      - uses: actions/checkout@v3
+      - uses: dtolnay/rust-toolchain@master
         with:
-          toolchain: stable
+          toolchain: ${{ matrix.toolchain }}
           components: clippy
-
       - name: Run clippy
         run: cargo clippy --all ${{ matrix.cargo_flags }} -- -D warnings
+
+   # Job to check that all the lint checks succeeded
+  clippy-check:
+    needs:
+    - clippy
+    runs-on: ubuntu-latest
+    if: always()
+    steps:
+      - run: jq --exit-status 'all(.result == "success")' <<< '${{ toJson(needs) }}'

.github/workflows/clippy.yaml

@@ -1,24 +1,18 @@
-
 on:
   push:
     branches: [ staging, trying, master ]
   pull_request:
+  merge_group:
 
 name: Code formatting check
 
 jobs:
-  fmt:
-    name: Rustfmt
-    runs-on: ubuntu-20.04
+  rustfmt:
+    runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions-rs/toolchain@v1
+      - uses: actions/checkout@v3
+      - uses: dtolnay/rust-toolchain@stable
         with:
-          profile: minimal
-          toolchain: stable
-          override: true
           components: rustfmt
-      - uses: actions-rs/cargo@v1
-        with:
-          command: fmt
-          args: --all -- --check
+      - name: Run Rustfmt
+        run: cargo fmt --all -- --check --verbose

.github/workflows/rustfmt.yaml

@@ -13,6 +13,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Add `asm::fence()`, a wrapper for implementing a `fence` instruction
 - Add `asm::fence_i()`, a wrapper for implementing a `fence.i` instruction
 
+### Changed
+
+- CI actions updated. They now use `checkout@v3` and `dtolnay/rust-toolchain`.
+
 ## [v0.10.1] - 2023-01-18
 
 ### Fixed