fix clippy lints

Author: burrbull

svd-parser/src/elementext.rs

@@ -34,12 +34,7 @@ impl<'a, 'input> ElementExt for Node<'a, 'input> {
     where
         K: AsRef<str>,
     {
-        for c in self.children() {
-            if c.has_tag_name(k.as_ref()) {
-                return Some(c);
-            }
-        }
-        None
+        self.children().find(|&c| c.has_tag_name(k.as_ref()))
     }
     fn get_child_text_opt<K>(&self, k: K) -> Result<Option<String>, SVDErrorAt>
     where

svd-parser/src/expand.rs

@@ -571,11 +571,11 @@ pub fn derive_enumerated_values(
             Ok(epath)
         }
     } else {
-        return Err(anyhow!(
+        Err(anyhow!(
             "enumeratedValues {} not found, parent field: {:?}",
             dpath,
             fpath,
-        ));
+        ))
     }
 }
 

svd-parser/src/lib.rs

@@ -220,7 +220,7 @@ pub mod expand;
 #[cfg(feature = "expand")]
 pub use expand::{expand, expand_properties};
 /// SVD parse Errors.
-#[derive(Clone, Debug, PartialEq, thiserror::Error)]
+#[derive(Clone, Debug, PartialEq, Eq, thiserror::Error)]
 pub enum SVDError {
     #[error("{0}")]
     Svd(#[from] svd::SvdError),

svd-rs/src/access.rs

@@ -1,7 +1,7 @@
 /// Defines access rights for fields on the device, though it may be specified at a
 /// higher level than individual fields.
 #[cfg_attr(feature = "serde", derive(serde::Deserialize, serde::Serialize))]
-#[derive(Clone, Copy, Debug, PartialEq)]
+#[derive(Clone, Copy, Debug, PartialEq, Eq)]
 pub enum Access {
     /// Read access is permitted. Write operations have an undefined effect.
     #[cfg_attr(feature = "serde", serde(rename = "read-only"))]

svd-rs/src/addressblock.rs

@@ -2,7 +2,7 @@ use super::{BuildError, Protection, SvdError, ValidateLevel};
 
 ///  An uniquely mapped address block to a peripheral
 #[cfg_attr(feature = "serde", derive(serde::Deserialize, serde::Serialize))]
-#[derive(Clone, Debug, PartialEq)]
+#[derive(Clone, Debug, PartialEq, Eq)]
 #[non_exhaustive]
 pub struct AddressBlock {
     /// Specifies the start address of an address block relative to the peripheral [`baseAddress`](crate::Peripheral::base_address).
@@ -63,7 +63,7 @@ impl AddressBlockUsage {
 }
 
 /// Builder for [`AddressBlock`]
-#[derive(Clone, Debug, Default, PartialEq)]
+#[derive(Clone, Debug, Default, PartialEq, Eq)]
 pub struct AddressBlockBuilder {
     offset: Option<u32>,
     size: Option<u32>,

svd-rs/src/array.rs

@@ -2,7 +2,7 @@ use super::{DimElement, Name};
 use core::ops::{Deref, DerefMut};
 
 /// A single SVD instance or array of instances
-#[derive(Clone, Debug, PartialEq)]
+#[derive(Clone, Debug, PartialEq, Eq)]
 pub enum MaybeArray<T> {
     /// A single instance
     Single(T),

svd-rs/src/bitrange.rs

@@ -7,7 +7,7 @@ pub enum Error {
 }
 
 /// A bit range, describing the [least significant bit](Self::lsb) and [most significant bit](Self::msb)
-#[derive(Clone, Copy, Debug, PartialEq)]
+#[derive(Clone, Copy, Debug, PartialEq, Eq)]
 pub struct BitRange {
     /// Value defining the position of the least significant bit of the field within the register
     pub offset: u32,
@@ -20,7 +20,7 @@ pub struct BitRange {
 }
 
 /// The style of bit range that describes a [BitRange]
-#[derive(Clone, Copy, Debug, PartialEq)]
+#[derive(Clone, Copy, Debug, PartialEq, Eq)]
 pub enum BitRangeType {
     /// A bit range in the format: `[<msb>:<lsb>]`
     BitRange,

svd-rs/src/cpu.rs

@@ -5,7 +5,7 @@ use super::{BuildError, Endian, SvdError, ValidateLevel};
     derive(serde::Deserialize, serde::Serialize),
     serde(rename_all = "camelCase")
 )]
-#[derive(Clone, Debug, PartialEq)]
+#[derive(Clone, Debug, PartialEq, Eq)]
 #[non_exhaustive]
 pub struct Cpu {
     /// Processor architecture
@@ -99,7 +99,7 @@ pub struct Cpu {
 }
 
 /// Builder for [`Cpu`]
-#[derive(Clone, Debug, Default, PartialEq)]
+#[derive(Clone, Debug, Default, PartialEq, Eq)]
 pub struct CpuBuilder {
     name: Option<String>,
     revision: Option<String>,

svd-rs/src/dimelement.rs

@@ -8,7 +8,7 @@ use std::ops::RangeInclusive;
     derive(serde::Deserialize, serde::Serialize),
     serde(rename_all = "camelCase")
 )]
-#[derive(Clone, Debug, PartialEq)]
+#[derive(Clone, Debug, PartialEq, Eq)]
 #[non_exhaustive]
 pub struct DimElement {
     /// Defines the number of elements in an array or list
@@ -55,7 +55,7 @@ pub struct DimElement {
     derive(serde::Deserialize, serde::Serialize),
     serde(rename_all = "camelCase")
 )]
-#[derive(Clone, Debug, PartialEq)]
+#[derive(Clone, Debug, PartialEq, Eq)]
 pub struct DimArrayIndex {
     /// Specify the base name of enumerations
     #[cfg_attr(
@@ -69,7 +69,7 @@ pub struct DimArrayIndex {
 }
 
 /// Builder for [`DimElement`]
-#[derive(Clone, Debug, Default, PartialEq)]
+#[derive(Clone, Debug, Default, PartialEq, Eq)]
 pub struct DimElementBuilder {
     dim: Option<u32>,
     dim_increment: Option<u32>,

svd-rs/src/endian.rs

@@ -4,7 +4,7 @@
     derive(serde::Deserialize, serde::Serialize),
     serde(rename_all = "kebab-case")
 )]
-#[derive(Clone, Copy, Debug, PartialEq)]
+#[derive(Clone, Copy, Debug, PartialEq, Eq)]
 pub enum Endian {
     /// Little endian.
     Little,